Skip to content

[3.10] [doc] Reword sentinel object summary in dataclasses (GH-27792) #28130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

[3.10] [doc] Reword sentinel object summary in dataclasses (GH-27792) #28130

merged 1 commit into from
Sep 2, 2021

Conversation

miss-islington
Copy link
Contributor

This sentinel value (MISSING) is also used as default value for the kw_only parameter introduced in Python 3.10. It's cleaner to simply omit the usage here.

Co-authored-by: Łukasz Langa [email protected]
(cherry picked from commit 767a17f)

Co-authored-by: Ville Korhonen [email protected]

@ypcs @miss-islington
[doc] Reword sentinel object summary in dataclasses (pythonGH-27792)
20707a2 
This sentinel value (`MISSING`) is also used as default value for the `kw_only` parameter introduced in Python 3.10. It's cleaner to simply omit the usage here.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 767a17f)

Co-authored-by: Ville Korhonen <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Sep 2, 2021
Merged
@bedevere-bot bedevere-bot added skip issue skip news docs Documentation in the Doc dir labels Sep 2, 2021
@miss-islington
Copy link
Contributor Author

@ypcs and @ambv: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor Author

@ypcs and @ambv: Status check is done, and it's a success ✅ .

3 similar comments
@miss-islington
Copy link
Contributor Author

@ypcs and @ambv: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@ypcs and @ambv: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@ypcs and @ambv: Status check is done, and it's a success ✅ .

ambv
ambv approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc-only change.

@miss-islington miss-islington merged commit 7aa58f5 into python:3.10 Sep 2, 2021
@miss-islington miss-islington deleted the backport-767a17f-3.10 branch September 2, 2021 16:38
@miss-islington
Copy link
Contributor Author

@ypcs and @ambv: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv ambv approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @ambv @the-knights-who-say-ni @bedevere-bot @ypcs