Skip to content

Add missing sentinel obj reference to dataclasses documentation #27792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2021
Merged

Add missing sentinel obj reference to dataclasses documentation #27792

merged 2 commits into from
Sep 2, 2021

Conversation

ypcs
Copy link
Contributor

@ypcs ypcs commented Aug 17, 2021

This sentinel value (MISSING) is also used as default value for
kw_only parameter introduced in Python 3.10.

@ypcs
Fix documentation of dataclasses sentinel object
7b78b50 
This sentinel value (`MISSING`) is also used as default value for
`kw_only` parameter introduced in Python 3.10.
@ypcs ypcs requested a review from ericvsmith as a code owner August 17, 2021 09:27
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@ypcs

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Aug 17, 2021
ambv
ambv reviewed Aug 17, 2021
View reviewed changes
@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes and removed needs backport to 3.9 only security fixes labels Aug 17, 2021
ericvsmith
ericvsmith requested changes Aug 17, 2021
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ambv
ambv reviewed Sep 2, 2021
View reviewed changes
@ambv ambv merged commit 767a17f into python:main Sep 2, 2021
@miss-islington
Copy link
Contributor

Thanks @ypcs for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2021
@ypcs @miss-islington
[doc] Reword sentinel object summary in dataclasses (pythonGH-27792)
20707a2 
This sentinel value (`MISSING`) is also used as default value for the `kw_only` parameter introduced in Python 3.10. It's cleaner to simply omit the usage here.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 767a17f)

Co-authored-by: Ville Korhonen <[email protected]>
@bedevere-bot
Copy link

GH-28130 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 2, 2021
miss-islington added a commit that referenced this pull request Sep 2, 2021
@miss-islington @ypcs
[doc] Reword sentinel object summary in dataclasses (GH-27792)
7aa58f5 
This sentinel value (`MISSING`) is also used as default value for the `kw_only` parameter introduced in Python 3.10. It's cleaner to simply omit the usage here.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 767a17f)

Co-authored-by: Ville Korhonen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv ambv left review comments

@ericvsmith ericvsmith ericvsmith requested changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ypcs @the-knights-who-say-ni @bedevere-bot @miss-islington @ambv @ericvsmith