Skip to content

bpo-29506: Fixes documentation for usage of deepcopy in copy module #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2017
Merged

bpo-29506: Fixes documentation for usage of deepcopy in copy module #151

merged 3 commits into from
Apr 9, 2017

Conversation

CuriousLearner
Copy link
Member

Fixes issue: http://bugs.python.org/issue29506

Changes Steven's proposal to use word state instead of data as per suggestion from @ncoghlan

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@serhiy-storchaka serhiy-storchaka added the docs Documentation in the Doc dir label Feb 18, 2017
@CuriousLearner
Copy link
Member Author

CLA is signed and now visible in my account.

cc @ncoghlan

marco-buttu
marco-buttu reviewed Mar 27, 2017
View reviewed changes
Doc/library/copy.rst Outdated
@@ -47,8 +47,8 @@ copy operations:
* Recursive objects (compound objects that, directly or indirectly, contain a
reference to themselves) may cause a recursive loop.

* Because deep copy copies *everything* it may copy too much, e.g.,
even administrative data structures that should be shared even between copies.
* Because deep copy copies everything it may copy too much, such as state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CuriousLearner. IMO the @stevendaprano wording, that refers to "data which is intended to be shared" ("Because deep copy copies everything, it may copy too much, such as data which is intended to be shared between copies."), is more clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marco-buttu Sure, I will fix that.

@CuriousLearner
Copy link
Member Author

@marco-buttu I've done the changes, please have a look!

Thanks!

@marco-buttu
Copy link
Contributor

Thanks @CuriousLearner, it LGTM. @bitdancer proposed a shorten variant in pbo-29506:

Because deep copy copies everything, it may copy data that is intended to be shared between copies.

This variant also LGTM. Let's see what @bitdancer says.

@ncoghlan ncoghlan self-assigned this Apr 9, 2017
@ncoghlan ncoghlan merged commit 19e0494 into python:master Apr 9, 2017
@ncoghlan
Copy link
Contributor

ncoghlan commented Apr 9, 2017 •
edited
Loading

3.6: #1061
3.5: #1062
2.7: #1063

@ncoghlan
Copy link
Contributor

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

jaraco pushed a commit that referenced this pull request Dec 2, 2022
@zware @Mariatta
Normalize commit messages on automerge (#151)
c607cce 
Remove HTML comments and unwanted leading and trailing whitespace
from the commit message.

Fixes #150
lazka added a commit to lazka/cpython that referenced this pull request Aug 27, 2023
@lazka
LoadLibraryExW: make sure to only use backslashes for paths
99f705c 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
lazka added a commit to lazka/cpython that referenced this pull request Aug 27, 2023
@lazka
LoadLibraryExW: make sure to only use backslashes for paths
e8971f6 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Dec 31, 2023
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
7b18204 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 1, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
3b2c4e7 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 1, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
cdf7ec2 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 1, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
0689324 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 1, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
eefd047 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 1, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
0ca4538 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 1, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
c8408a0 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 1, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
bf731d4 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jan 1, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
8fb93e5 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
lazka added a commit to lazka/cpython that referenced this pull request Feb 10, 2024
@lazka
LoadLibraryExW: make sure to only use backslashes for paths
b6995a5 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Feb 19, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
87e6749 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Feb 19, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
e2d93ca 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Feb 19, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
e413156 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Feb 21, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
0f6b0cc 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jul 11, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
9497d60 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Jul 11, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
4cc1d85 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
lazka added a commit to lazka/cpython that referenced this pull request Aug 25, 2024
@lazka
LoadLibraryExW: make sure to only use backslashes for paths
16529b1 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Sep 4, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
a1a5bc3 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Sep 9, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
323a045 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
lazka added a commit to lazka/cpython that referenced this pull request Nov 2, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
3b97429 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Nov 2, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
1dfda7c 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Nov 2, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
212fb2b 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Dec 25, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
111b571 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Dec 25, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
e7d7afa 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Dec 25, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
62d6481 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Dec 25, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
04487f0 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Dec 25, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
b59f152 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
naveen521kk pushed a commit to naveen521kk/cpython that referenced this pull request Dec 27, 2024
@lazka @naveen521kk
LoadLibraryExW: make sure to only use backslashes for paths
ab9c0a7 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
lazka added a commit to lazka/cpython that referenced this pull request Feb 12, 2025
@lazka
LoadLibraryExW: make sure to only use backslashes for paths
ba1318d 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
lazka added a commit to lazka/cpython that referenced this pull request Apr 16, 2025
@lazka
LoadLibraryExW: make sure to only use backslashes for paths
e754b07 
It seems like in case the path passed to it is absolute, but contains
forward slashes then LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR does not work
and DLLs in the same directory as the extension are not considered.

This occurs in our fork because in MSYS2-mode the extension loader will
normalize to forward slashes before.

Normalize everything to backslashes again before passing it to LoadLibraryExW.

Fixes python#151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-buttu marco-buttu marco-buttu left review comments

Assignees

@ncoghlan ncoghlan

Labels
docs Documentation in the Doc dir sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@CuriousLearner @the-knights-who-say-ni @marco-buttu @ncoghlan @berkerpeksag @serhiy-storchaka @Mariatta