-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-27470: fix documentation for -3 commandline option not warning wh… #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
Doc/using/cmdline.rst
Outdated
|
||
.. versionadded:: 2.6 | ||
|
||
.. note:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a note directive is needed here. You can say something like
See :doc:`howto/pyporting` for more details.
I haven't checked whether :doc:`howto/pyporting` works or not so please build the docs locally and test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@berkerpeksag thanks for pointing out, fixed it.
…en incompatibilities can't be detected using static code analysis
@berkerpeksag's review has been addressed. Thanks for the PR, @ghost-script 🌮 |
…_api.h Add the missing prototype of long PyStackless_GetCurrentId(void) to stackless_api.h
Commit aefa7eb in version 3.7.0a0 changed the type of thread id from "long" to "unsigned long". This commit adapts Stackless to the new type. See https://bugs.python.org/issue6532
…_api.h Add the missing prototype of long PyStackless_GetCurrentId(void) to stackless_api.h (cherry picked from commit aa6e04c)
A recently introduced test case (see Stackless issue python#150) was buggy. It assumed sizeof(size_t) == sizeof(long) which is false on Windows x64.
Remove HTML comments and unwanted leading and trailing whitespace from the commit message. Fixes #150
fix documentation for -3 commandline option not warning when incompatibilities can't be detected using static code analysis
https://bugs.python.org/issue27470