Skip to content

Refactor and add framework for native jfr event support #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zhengyu123
Copy link
Contributor

This PR replaces PR#3746

  • Split JFR package into hosted (com.oracle.svm.hosted.jdk11.jfr) and core (com.oracle.svm.core.jdk11.jfr)
  • Add package com.oracle.svm.core.jfr for native jfr event support (e.g. GC events)
  • There will no-op JfrEventSupport for jdk8, but a concrete implementation for jdk11 or later
  • Remove com.oracle.svm.jfr package

@jerboaa
Copy link
Collaborator

jerboaa commented Sep 16, 2021

@zhengyu123 If you rebase this onto latest master, it should pass all the public gate tests.

@zhengyu123 zhengyu123 force-pushed the refactor-jfr-for-native-event branch from e99e016 to 47aeaa3 Compare September 29, 2021 23:36
@@ -570,46 +599,6 @@
"spotbugs": "false",
},

"com.oracle.svm.jfr": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to have the JFR implementation (and its dependencies) in a separate project. Pretty much all VM-internal events should use the JfrNativeEventWriter anyways (via some JDK-independent abstraction).

@christianhaeubl
Copy link
Member

I will merge the PR #3720 first, as it is more complex than this PR. After that, I will merge this PR and as part of that process, I am also going to take care of all the conflicts that may come up. So, there is no need on your end to rebase this PR.

@jiekang
Copy link
Collaborator

jiekang commented Dec 10, 2021

@christianhaeubl Hi Christian! Any updates on this area?

@christianhaeubl
Copy link
Member

@jiekang I would like to wait with this until the JDK 8 support is removed from Native Image as the JFR refactoring will be far simpler afterwards. The removal of the JDK 8 support is currently work in progress and should be finished soon.

@christianhaeubl
Copy link
Member

I am closing this PR as I merged my PR in the meanwhile. Most JFR-related files are now part of the project com.oracle.svm.core and can therefore be used easily in other Native Image projects (e.g., in the GC).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants