-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Refactor and add framework for native jfr event support #3770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and add framework for native jfr event support #3770
Conversation
01137c3
to
8d1d338
Compare
@zhengyu123 If you rebase this onto latest master, it should pass all the public gate tests. |
e99e016
to
47aeaa3
Compare
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/JfrEventSupport.java
Outdated
Show resolved
Hide resolved
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jfr/JfrEventSupport.java
Outdated
Show resolved
Hide resolved
@@ -570,46 +599,6 @@ | |||
"spotbugs": "false", | |||
}, | |||
|
|||
"com.oracle.svm.jfr": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to have the JFR implementation (and its dependencies) in a separate project. Pretty much all VM-internal events should use the JfrNativeEventWriter
anyways (via some JDK-independent abstraction).
I will merge the PR #3720 first, as it is more complex than this PR. After that, I will merge this PR and as part of that process, I am also going to take care of all the conflicts that may come up. So, there is no need on your end to rebase this PR. |
@christianhaeubl Hi Christian! Any updates on this area? |
@jiekang I would like to wait with this until the JDK 8 support is removed from Native Image as the JFR refactoring will be far simpler afterwards. The removal of the JDK 8 support is currently work in progress and should be finished soon. |
I am closing this PR as I merged my PR in the meanwhile. Most JFR-related files are now part of the project |
This PR replaces PR#3746