Skip to content

Add JFR events for the garbage collector #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiekang opened this issue Aug 31, 2021 · 3 comments
Closed

Add JFR events for the garbage collector #3743

jiekang opened this issue Aug 31, 2021 · 3 comments

Comments

@jiekang
Copy link
Collaborator

jiekang commented Aug 31, 2021

As title says. It would be nice to have events to cover configuration, pauses, heap and metaspace data.

@jiekang
Copy link
Collaborator Author

jiekang commented Aug 31, 2021

@christianhaeubl @christianwimmer

Hi! We'll be looking to add these. However there is one significant blocker at the moment, the location of code:

JFR is in com.oracle.svm.jfr
GC is in com.oracle.svm.core.genscavenge

How do you envision JFR events are added to core functionality, including more than the GC? Do we move the 'native' bits into com.oracle.svm.core.jfr? Or maybe expose some kind of listener API for core pieces similar to com.oracle.svm.core.thread.ThreadListenerSupport?

@christianwimmer
Copy link

@jiekang The GC projects (like genscavenge) should implement the JFR support directly without any further indirection. I think this can be achieved fairly easily by splitting the current com.oracle.svm.jfr project into a com.oracle.svm.core.jfr and com.oracle.svm.hosted.jfr part. The core part depends only on the svm.core project, and then genscavenge can depend on svm.core.jfr.

Looking at the source code (but without doing any refactoring myself), I think there are very few parts that need to be in svm.hosted.jfr. I see JfrFeature and JfrEventSubstitution have imports from svm.hosted, but nothing else.

@jiekang jiekang removed their assignment Mar 1, 2023
@fernando-valdez fernando-valdez self-assigned this Jan 17, 2024
@fernando-valdez
Copy link
Member

Native JFR event support changes merged from this PR #3770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants