Skip to content

Bump parity scale codec to v2 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021
Merged

Bump parity scale codec to v2 #128

merged 1 commit into from
May 26, 2021

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented May 26, 2021

waiting for #127 to be merged firstly

Close #118

@koushiro
Copy link
Contributor Author

@vmx PTAL

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this change looks good. Please rebase once #127 is merged.

@vmx vmx mentioned this pull request May 26, 2021
@koushiro koushiro requested a review from vmx May 26, 2021 14:43
@vmx vmx merged commit db813e2 into multiformats:master May 26, 2021
@vmx
Copy link
Member

vmx commented May 26, 2021

I had "spend time maintaining rust-multihash" on my todo list. It's great to see that you put effort into this. Thanks @koushiro for the really quick turnaround times and putting so much effort into it.

@koushiro koushiro deleted the bump-parity-scale-codec branch May 26, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants