Skip to content

*: Remove parity-scale-codec #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Apr 30, 2021

Given that there are no known users of the scale encoding feature, this
commit removes it, making overall maintenance easier.

For more details see:
#118

Given that there are no known users of the scale encoding feature, this
commit removes it, making overall maintenance easier.

For more details see:
multiformats#118
@mxinden
Copy link
Member Author

mxinden commented Apr 30, 2021

Note that this breaks rust-cid, see multiformats/rust-cid#72.

@rklaehn
Copy link
Collaborator

rklaehn commented May 3, 2021

So does parity use parity-scale-codec in rust-cid? I am always in favour of removing things, but if parity uses parity-scale-codec via rust-cid, I guess we should not do it...

@dvc94ch
Copy link
Collaborator

dvc94ch commented May 3, 2021

Someone might complain. But parity doesn't use it directly, if anything one of their customers (people who buy dot).

@mxinden
Copy link
Member Author

mxinden commented May 5, 2021

@tomaka would you mind dropping this in some Parity internal channel to give it more visibility?

In case no one objects I would suggest merging in a week. In the unlikely case where someone still needs it, but only finds out after a release, we can still revert it.

@dvc94ch
Copy link
Collaborator

dvc94ch commented May 5, 2021

I think a guy from social network or whatever it's called (original name for a social network) sometimes posts on the rust-ipfs riot mentioned he was using it.

@vmx
Copy link
Member

vmx commented May 26, 2021

Given that there are peiple using the parity-scale-codec in rust-cid and care about it (see #128) I think we should close this issue.

@mxinden mxinden closed this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants