Replace start-docker.sh with docker-compose.yml #422
Conversation
|
Does this still run |
xhost should no longer be needed as |
There was a problem hiding this comment.
Hello @smartin015 thank you so much for the PR, this is way nicer than scripting! I did test this and was able to get it to work with a few changes, that I mentioned below. I have a few nitpicky comments, appreciate if you can take them a look, otherwise, it's all good. Thank you so much!
Co-authored-by: Vatan Aksoy Tezer <[email protected]>
…als into docker_compose
|
Thank you very much @smartin015 for the contribution, much appreciated! All looks good to me! |
vatanaksoytezer
added
backport-foxy
(cherry picked from commit 352061d) # Conflicts: # doc/how_to_guides/how_to_setup_docker_containers_in_ubuntu.rst
(cherry picked from commit 352061d) # Conflicts: # doc/how_to_guides/how_to_setup_docker_containers_in_ubuntu.rst
(cherry picked from commit 352061d) # Conflicts: # doc/how_to_guides/how_to_setup_docker_containers_in_ubuntu.rst
|
With the latest @smartin015: what sort of system are you running? Edit: the system I tried this on doesn't appear to have The After changing the volume mount to read Having written that: I don't know whether this is a secure way of allowing access to the X server from the Docker container. |
| environment: | ||
| DISPLAY: $DISPLAY |
There was a problem hiding this comment.
@smartin015: I'm wondering if this works as intended.
According to the YAML spec (edit: merge keys only made it into 1.1 as a draft) and my testing, this does not override/merge environment into the environment map specified in x-base-gpu, which doesn't override/merge the environment map specified in x-base-cpu.
I've had to do something like this to get it to work:
x-base-cpu: &base-cpu
...
environment: &base-cpu-env
QT_X11_NO_MITSHM: 1
...
x-base-gpu: &base-gpu
<<: *base-cpu
...
environment: &base-gpu-env
<<: *base-cpu-env
NVIDIA_VISIBLE_DEVICES: all
NVIDIA_DRIVER_CAPABILITIES: all
services:
...
gpu:
<<: *base-gpu
...
environment:
<<: *base-gpu-env
DISPLAY: $DISPLAYcould you perhaps verify QT_X11_NO_MITSHM is being set in the gpu container @smartin015? env | sort didn't show it for me, unless I made the above changes.
There was a problem hiding this comment.
My bad on testing somewhat I may have misused some settings while testing. I can confirm what @gavanderhoorn says here. The docker container launches fine but the display isn't working. This fix seems to set the correct environment variables as suggested, but unfortunately, the display wasn't working for me (ie: xeyes). I'm going to revert this change in a day if not resolved to keep non working stuff away from main.
There was a problem hiding this comment.
Apologies for the breakage - I opened #439 to remove the x-* templating since it may be a bit suspect. However, please do revert the change if you'd rather not try to fix forward. Better to have a working old path than a non-working new one :)
From a clean boot of my Ubuntu 22.04 computer, I ran the following with the new PR:
DOCKER_IMAGE=humble-source docker-compose run gpu /bin/bash
source install/setup.bash && ros2 run rviz2 rviz2
And it opens an rviz window as expected.
Running xhost command shows only SI:localuser:<my username>, so it seems that xhost isn't configured in any way beyond the defaults.
Description
Per observations/discussion in #404, this PR replaces the original
start-docker.shscript with adocker-compose.ymlscript. The same features are available in both, but using a compose file is less custom and easier to customize. It uses an anonymous volume - all changes in/rootare persisted between runs.Also fixes a couple of typos I found in the tutorials :)
@vatanaksoytezer please give this script a shot and let me know if there's anything you'd like me to change (e.g. if you'd prefer to also keep the script so folks have a fallback)
Checklist