Recognize object literal method JSDoc comments #6870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1220,6 +1220,11 @@ namespace ts { | |||
| if (isSourceOfAssignmentExpressionStatement) { | |||
| return node.parent.parent.jsDocComment; | |||
| } | |||
|
|
|||
| const isPropertyAssignmentExpression = node.parent && node.parent.kind === SyntaxKind.PropertyAssignment; | |||
There was a problem hiding this comment.
parent gets used quite a lot here and above - consider declaring a parent constant.
| @@ -3960,7 +3960,7 @@ namespace ts { | |||
| shorthandDeclaration.equalsToken = equalsToken; | |||
| shorthandDeclaration.objectAssignmentInitializer = allowInAnd(parseAssignmentExpressionOrHigher); | |||
| } | |||
| return finishNode(shorthandDeclaration); | |||
| return addJSDocComment(finishNode(shorthandDeclaration)); | |||
There was a problem hiding this comment.
I notice this function returns early if tryParseAccessorDeclaration is successful (or via parseMethodDeclaration@3943). Do we handle those cases, such as getters/setters? (Good tests to add also).
|
Minor comment with additional use case to check (which could be separate issue, as lower pri), else 👍 |
RyanCavanaugh
added a commit
that referenced
this pull request
Feb 4, 2016
Recognize object literal method JSDoc comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6825