Skip to content

[0.10.7-insider] Salsa does not honor JSDoc for object methods #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
egamma opened this issue Feb 2, 2016 · 1 comment
Closed

[0.10.7-insider] Salsa does not honor JSDoc for object methods #6825

egamma opened this issue Feb 2, 2016 · 1 comment
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@egamma
Copy link
Member

egamma commented Feb 2, 2016

From @astral-sa on February 2, 2016 6:24

Testing Salsa on 0.10.7-insider (6c2d51a)
[email protected]
typescript.tsdk properly configured

Similar to #2440 (#6552) for #2218:

var someObject = {
    /**
     * @param {string} param1 Some string param.
     * @param {number} parm2  Some number param.
     */
    someMethod: function(param1, param2) {
        console.log(param1);
        return false;
    }
};

salsa_method

Copied from original issue: microsoft/vscode#2630

@billti
Copy link
Member

billti commented Feb 2, 2016

Yeah, this is going to be pretty common. @RyanCavanaugh How much work is adding this going to be? Something we could get in for 1.8.2 perhaps?

@billti billti added this to the TypeScript 1.8.2 milestone Feb 2, 2016
@mhegazy mhegazy added the Bug A bug in TypeScript label Feb 2, 2016
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue Feb 3, 2016
@RyanCavanaugh RyanCavanaugh added the Fixed A PR has been merged for this issue label Feb 3, 2016
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this issue Feb 5, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

4 participants