Skip to content

Fix template string escaping #60303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix template string escaping #60303

merged 2 commits into from
Oct 21, 2024

Conversation

rbuckton
Copy link
Contributor

This fixes the RegExp we use to escape characters for template strings to properly exclude LF characters when the template string is synthetic.

Fixes #59150

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 21, 2024
@rbuckton
Copy link
Contributor Author

@DanielRosenwasser any concerns with taking this for RC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Printer): LF newline in template strings is escaped when it shouldn't be
5 participants