Port TypeScript PR #60303: Fix template string escaping for control characters #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the fix from microsoft/TypeScript#60303 which corrected template string escaping behavior for control characters.
Problem
The template string escaping logic had a subtle bug where the
\u001f
control character (Unit Separator) was not being escaped when it should have been. The conditionch < '\u001f'
was excluding\u001f
itself from the escaping logic.Solution
Changed the condition from
ch < '\u001f'
toch <= '\u001f'
in theescapeStringWorker
function to properly include all control characters up to and including\u001f
.Changes Made
Fixed escaping condition in
internal/printer/utilities.go
:Added comprehensive test cases to verify:
\n
) is NOT escaped in template strings (backticks) ✓\u0001
,\u001f
ARE escaped in template strings ✓\t
) and vertical tab (\v
) are properly escaped ✓Updated test baselines for
templateStringControlCharacterEscapes03
tests that now correctly escape control characters.Verification
The fix was verified by:
Fixes #15.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.