Actual signature help trigger filtering #25422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
changed the title
DanielRosenwasser
force-pushed
the
actualSignatureHelpTriggers
branch
from
033aab8 to
9481faa
Compare
mhegazy
approved these changes
Jul 6, 2018
weswigham
reviewed
Jul 6, 2018
| @@ -1515,7 +1515,9 @@ Actual: ${stringify(fullActual)}`); | |||
| "argumentCount", | |||
| ]; | |||
| for (const key in options) { | |||
| ts.Debug.assert(ts.contains(allKeys, key)); | |||
| if (!ts.contains(allKeys, key)) { | |||
| ts.Debug.fail("Unexpected key " + key); | |||
There was a problem hiding this comment.
You should return ts.Debug.fail("Unexpected key " + key);, probably.
There was a problem hiding this comment.
I usually only do that when the compiler needs to know more about reachability, but I don't think it's necessary here unless I'm missing something.
There was a problem hiding this comment.
We were talking about making it a lint rule a few weeks ago, that way the reachability graph is more complete and may expose more logic bugs (eg, can a following if statement never actually occur because of the implied throw here).
|
🎉 |
This was referenced Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25393.