Skip to content

Block on other signature help triggers #25393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielRosenwasser opened this issue Jul 3, 2018 · 1 comment
Closed

Block on other signature help triggers #25393

DanielRosenwasser opened this issue Jul 3, 2018 · 1 comment
Assignees
Labels
Bug A bug in TypeScript Domain: Signature Help Information in editor tooltips when invoking a function call Fixed A PR has been merged for this issue

Comments

@DanielRosenwasser
Copy link
Member

#24915 implemented trigger characters for signature help, but only blocked signature help inside of a string.

As @mhegazy mentioned in #24915 (comment), we still need to block character triggers:

  • In parenthesized expressions
  • In comments
  • In JSX text
  • On commas outside of argument lists
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.0.1 milestone Jul 3, 2018
@ghost ghost added Domain: Signature Help Information in editor tooltips when invoking a function call Bug A bug in TypeScript labels Jul 3, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jul 3, 2018

@DanielRosenwasser u promised to get this in shortly after #24915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Signature Help Information in editor tooltips when invoking a function call Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants