Skip to content

Do we need "Invoke Injectable" rule? #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lazarljubenovic opened this issue Mar 6, 2017 · 4 comments
Closed

Do we need "Invoke Injectable" rule? #260

lazarljubenovic opened this issue Mar 6, 2017 · 4 comments
Assignees
@mgechev

Comments

@lazarljubenovic
Copy link
Contributor

Do we really need this as a rule? TypeScript simply fails if it's not invoked:

Error:(16, 1) TS1238:Unable to resolve signature of class decorator when called as an expression.
  Supplied parameters do not match any signature of call target.

I see it being suggested in #70, but is really all that "mysteriously"? My IDE (WS) also clearly underlines it.
@mgechev
Copy link
Owner

mgechev commented Mar 6, 2017

Good point. There should be a clean-up. Few rules which are no longer required are:

  • templates-use-public
  • no-access-missing-member
  • invoke-injectable

The final one is handled by the tsc, first two by ngc.

@mgechev mgechev self-assigned this Mar 6, 2017
@mgechev
Copy link
Owner

mgechev commented Mar 7, 2017

#264

@mgechev mgechev closed this as completed Mar 7, 2017
@ibqn ibqn mentioned this issue Nov 6, 2017
Closed
gldraphael added a commit to gldraphael/chordsheet-editor that referenced this issue Dec 7, 2017
@gldraphael
Remove the invoke-injectable tslint rule
1c69d52 
See mgechev/codelyzer#260
@ghost
Copy link

ghost commented Dec 7, 2017

wow, I took some time to figure out why ng lint --type-check was giving me errors about missing rules after the update. I couldn't find documentation about these rules until I found this issue and found out they were removed by a codelyzer new version

@ghost
Copy link

ghost commented Dec 7, 2017

Nevermind, I figured out I should've gone to read the changelog instead of googleing the rule

https://github.com/mgechev/codelyzer/blob/master/CHANGELOG.md

gldraphael added a commit to gldraphael/chordsheet-editor that referenced this issue Dec 8, 2017
@gldraphael
Remove the invoke-injectable tslint rule
6c44e39 
See mgechev/codelyzer#260
@markgoho-EDT markgoho-EDT mentioned this issue Apr 15, 2018
Closed
liwde added a commit to Aam-Digital/ndb-core that referenced this issue Dec 2, 2018
@liwde
Remove rules that were deprecated and removed
db1fa98 
To reduce warnings.
see mgechev/codelyzer#260
pstjean added a commit to PRX/publish.prx.org that referenced this issue Feb 11, 2019
@pstjean
Remove deprecated rules mgechev/codelyzer#260
f19ab0a
pmstss added a commit to pmstss/amazing-time-picker that referenced this issue Mar 14, 2019
@pmstss
tslint/codelyzer config fix:
470055b 
- templates-use-public/no-access-missing-member (not more exist as handled by tsc - mgechev/codelyzer#260 (comment))
- invoke-injectable (not more exist as handled by ngc - mgechev/codelyzer#260 (comment))
- use-input*/use-output*/use-host* renamed - mgechev/codelyzer#754
- "typeof-compare is deprecated. Starting from TypeScript 2.2 the compiler includes this check which makes this rule redundant"
@alan-agius4 alan-agius4 mentioned this issue Feb 27, 2020
Closed
15 tasks
@micahstubbs micahstubbs mentioned this issue May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgechev mgechev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgechev @lazarljubenovic