Skip to content

remove missing helix-front tslint linting rules to fix warnings #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2022
Merged

remove missing helix-front tslint linting rules to fix warnings #2077

merged 1 commit into from
May 17, 2022

Conversation

micahstubbs
Copy link
Contributor

Description

This PR removes helix-front tslint linting rules that are missing implementations to fix warnings when running npm run lint.

Issues

fix #2076

Tests

npm run lint

> [email protected] lint /Users/m/workspace/helix/helix-front
> ng lint

All files pass linting.

@qqu0127
Copy link
Contributor

qqu0127 commented May 2, 2022

Thank you Micah for the fix. Just curious, are these rules removed in the new angular and codelyzer version? And do they provide any equivalent lint solutions?

@micahstubbs
Copy link
Contributor Author

micahstubbs commented May 2, 2022 •
edited
Loading

@qqu0127 good questions.

The rules no-access-missing-member, templates-use-public were removed from codelyzer sometime before January 2018. Reading the comments from mgechev/codelyzer#488, it does not appear that there are equivalent replacement rules for these two.

@micahstubbs
Copy link
Contributor Author

@qqu0127 invoke-injectable was a rule made redundant by TypeScript sometime before March 2017. mgechev/codelyzer#260

qqu0127
qqu0127 approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@qqu0127 qqu0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micahstubbs
Copy link
Contributor Author

Thanks for the review @qqu0127 🙏

@micahstubbs micahstubbs mentioned this pull request May 11, 2022
Closed
@somecodemonkey
Copy link

LGTM

@junkaixue
Copy link
Contributor

Please follow: https://github.com/apache/helix/wiki/Pull-Request-Merge-Steps

@micahstubbs
Copy link
Contributor Author

micahstubbs commented May 13, 2022 •
edited
Loading

This PR is ready to be merged.

final commit message

remove missing helix-front tslint linting rules to fix warnings

@junkaixue junkaixue merged commit aadd57e into apache:master May 17, 2022
@micahstubbs micahstubbs deleted the micahstubbs/2076/missing-linting-rules branch May 18, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqu0127 qqu0127 qqu0127 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helix-front: Could not find implementations for linting rules
4 participants
@micahstubbs @qqu0127 @somecodemonkey @junkaixue