Rewrite String.p.match / RegExp.p[@@match] #19514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Josh-Cena merged 7 commits into mdn:main from Josh-Cena:rewrite-match

Aug 14, 2022

Member

Josh-Cena commented Aug 13, 2022

Summary

Motivation

Continuation of #19501. Part of #1454.

Supporting details

Related issues

Metadata

Adds a new document
Rewrites (or significantly expands) a document
Fixes a typo, bug, or other error

Josh-Cena requested a review from a team as a code owner

August 13, 2022 16:08

Josh-Cena requested review from sideshowbarker and removed request for a team

August 13, 2022 16:08

github-actions bot added the Content:JS label

Contributor

github-actions bot commented Aug 13, 2022 •

edited

Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match
Title: String.prototype.match()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/exec
Title: RegExp.prototype.exec()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/@@match
Title: RegExp.prototype[@@match]()
on GitHub

No new external URLs

(this comment was updated 2022-08-14 03:54:55.660566)


          Rewrite String.p.match / RegExp.p[@@match]

96f6e62

Josh-Cena force-pushed the rewrite-match branch from ac4c7bc to 96f6e62 Compare

August 13, 2022 16:22

sideshowbarker reviewed

View reviewed changes

files/en-us/web/javascript/reference/global_objects/regexp/@@match/index.md Outdated Show resolved Hide resolved

sideshowbarker reviewed

View reviewed changes

files/en-us/web/javascript/reference/global_objects/regexp/@@match/index.md Outdated Show resolved Hide resolved


          Update files/en-us/web/javascript/reference/global_objects/regexp/@@m…

f956685

…atch/index.md

sideshowbarker reviewed

View reviewed changes

files/en-us/web/javascript/reference/global_objects/regexp/exec/index.md Outdated Show resolved Hide resolved


          Update files/en-us/web/javascript/reference/global_objects/regexp/exe…

54dcf43

…c/index.md

sideshowbarker reviewed

View reviewed changes

files/en-us/web/javascript/reference/global_objects/string/match/index.md Outdated Show resolved Hide resolved

sideshowbarker reviewed

View reviewed changes

files/en-us/web/javascript/reference/global_objects/string/match/index.md Outdated Show resolved Hide resolved

sideshowbarker reviewed

View reviewed changes

files/en-us/web/javascript/reference/global_objects/string/match/index.md Outdated Show resolved Hide resolved


          Update files/en-us/web/javascript/reference/global_objects/string/mat…

6aea246

…ch/index.md

sideshowbarker approved these changes

View reviewed changes

Member

sideshowbarker left a comment

LGTM with minor proofreading edits

Josh-Cena and others added 3 commits

August 14, 2022 11:51


          Update files/en-us/web/javascript/reference/global_objects/regexp/@@m…

7f67a36

…atch/index.md

Co-authored-by: Michael[tm] Smith <[email protected]>


          Update files/en-us/web/javascript/reference/global_objects/string/mat…

…ch/index.md

Co-authored-by: Michael[tm] Smith <[email protected]>


          Update files/en-us/web/javascript/reference/global_objects/string/mat…

4a18da8

…ch/index.md

Co-authored-by: Michael[tm] Smith <[email protected]>

Josh-Cena merged commit 48ecf83 into mdn:main

Josh-Cena deleted the rewrite-match branch

August 14, 2022 04:03

This was referenced Aug 14, 2022

Improve String.p.{search,matchAll} description #19535

Merged

group missing in RegExp. exec return value description #19554

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels