-
Notifications
You must be signed in to change notification settings - Fork 22.7k
Rewrite String.p.replace() #19501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rewrite String.p.replace() #19501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e72029
to
4c5649e
Compare
31326a4
to
bf0c261
Compare
bf0c261
to
798d7f1
Compare
Signed-off-by: Joshua Chen <[email protected]>
5044599
to
70349e5
Compare
3 tasks
files/en-us/web/javascript/reference/global_objects/regexp/@@replace/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/string/replace/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/string/replace/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/string/split/index.md
Outdated
Show resolved
Hide resolved
sideshowbarker
approved these changes
Aug 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor proofreading edits
…lace/index.md Co-authored-by: Michael[tm] Smith <[email protected]>
…it/index.md Co-authored-by: Michael[tm] Smith <[email protected]>
Thanks for the edits @sideshowbarker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation based on #17861 (comment). Part of the effort to address #1454
Motivation
Supporting details
Related issues
Metadata