Skip to content

Rewrite String.p.replace() #19501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 14, 2022
Merged

Rewrite String.p.replace() #19501

merged 9 commits into from
Aug 14, 2022

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented Aug 13, 2022

Summary

Continuation based on #17861 (comment). Part of the effort to address #1454

Motivation

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@Josh-Cena Josh-Cena requested a review from a team as a code owner August 13, 2022 08:52
@Josh-Cena Josh-Cena requested review from sideshowbarker and removed request for a team August 13, 2022 08:52
@github-actions github-actions bot added the Content:JS JavaScript docs label Aug 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2022

Preview URLs

Flaws

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/@@replace
Title: RegExp.prototype[@@replace]()
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/Web/Web/JavaScript/Reference/Global_Objects/String/replace#specifying_a_string_as_the_replacement
    • Can't resolve /en-US/Web/Web/JavaScript/Reference/Global_Objects/String/replace#specifying_a_function_as_the_replacement

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split
Title: String.prototype.split()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll
Title: String.prototype.replaceAll()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace
Title: String.prototype.replace()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/@@replace
Title: RegExp.prototype[@@replace]()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/@@split
Title: RegExp.prototype[@@split]()
on GitHub

No new external URLs

(this comment was updated 2022-08-14 04:04:24.361035)

@Josh-Cena Josh-Cena force-pushed the rewrite-replace branch 2 times, most recently from 8e72029 to 4c5649e Compare August 13, 2022 09:12
@Josh-Cena Josh-Cena force-pushed the rewrite-replace branch 2 times, most recently from 31326a4 to bf0c261 Compare August 13, 2022 10:21
Copy link
Member

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor proofreading edits

@Josh-Cena
Copy link
Member Author

Thanks for the edits @sideshowbarker!

@Josh-Cena Josh-Cena merged commit f82233a into mdn:main Aug 14, 2022
@Josh-Cena Josh-Cena deleted the rewrite-replace branch August 14, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants