Skip to content

[Backport] Fixed some minor css issue #17366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2018
Merged

[Backport] Fixed some minor css issue #17366

merged 1 commit into from
Aug 14, 2018

Conversation

arnoudhgz
Copy link
Contributor

@arnoudhgz arnoudhgz commented Aug 4, 2018 •
edited by sidolov
Loading

Original Pull Request

#17228

lib/internal/Magento/Framework/View/Test/Unit/Url/_files/sourceImport.css:

  • @import statements should be at the top

lib/web/css/docs/docs.css:

  • Use green instead of #green

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@arnoudhgz
Fixed some minor css issue
9c7eea8 
**lib/internal/Magento/Framework/View/Test/Unit/Url/_files/sourceImport.css:**
+ `@import` statements should be at the top

**lib/web/css/docs/docs.css:**
+ Use `green` instead of `#green`
@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Area: Lib/Frontend Component: Framework/View Release Line: 2.1 labels Aug 4, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Aug 5, 2018
@magento-engcom-team magento-engcom-team merged commit 9c7eea8 into magento:2.1-develop Aug 14, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 14, 2018
ENGCOM-2652: [Backport] Fixed some minor css issue #17366
75dff22
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Area: Lib/Frontend Component: Framework/View Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
3 participants
@arnoudhgz @magento-engcom-team @sidolov