Skip to content

Fix minor css issues #17228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2018
Merged

Fix minor css issues #17228

merged 2 commits into from
Aug 1, 2018

Conversation

arnoudhgz
Copy link
Contributor

lib/internal/Magento/Framework/View/Test/Unit/Url/_files/sourceImport.css:

  • @import statements should be at the top

lib/web/css/docs/docs.css:

  • Use green instead of #green

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

arnoudhgz added 2 commits July 28, 2018 15:42
@arnoudhgz
Merge remote-tracking branch 'upstream/2.3-develop' into 2.3-develop
99f311c
@arnoudhgz
Fixed some minor css issue
7be9f2e 
**lib/internal/Magento/Framework/View/Test/Unit/Url/_files/sourceImport.css:**
+ `@import` statements should be at the top

**lib/web/css/docs/docs.css:**
+ Use `green` instead of `#green`
@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Area: Lib/Frontend Component: Framework/View labels Jul 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 30, 2018
@magento-engcom-team magento-engcom-team merged commit 7be9f2e into magento:2.3-develop Aug 1, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 1, 2018
ENGCOM-2602: Fix minor css issues #17228
bb03938
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

This was referenced Aug 4, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Area: Lib/Frontend Component: Framework/View Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arnoudhgz @magento-engcom-team @sidolov