Move Сarrier Сodes validation to service layer #131 #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2017 10:25
naydav
reviewed
Oct 26, 2017
| $errors[] = __('You can\'t configure "%field" because you have chosen Global Shipping configuration.', [ | ||
| 'field' => SourceInterface::CARRIER_LINKS | ||
| ]); | ||
| } | ||
|
|
||
| $availableCarriers = $this->shippingConfig->getAllCarriers(); |
There was a problem hiding this comment.
Looks like we should refactor this logic
Becuase if $carrierLinks is not array then we do not need to perform foreach
| try { | ||
| $this->_webApiCall($serviceInfo, ['source' => $expectedData]); | ||
| } catch (\Exception $e) { | ||
| self::assertEquals(\Magento\Framework\Webapi\Exception::HTTP_BAD_REQUEST, $e->getCode()); |
There was a problem hiding this comment.
Also, need to check all conditions (all error messages)
| */ | ||
| private $shippingConfig; | ||
|
|
||
| /** |
| self::assertEquals(\Magento\Framework\Webapi\Exception::HTTP_BAD_REQUEST, $e->getCode()); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Also, need to fix the other api-functional builds
We do not run api-functional builds on Travis, so we need to run them on local machine
And now we have broken tests
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Sep 13, 2021
L3 pr 20210908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description