Skip to content

Move Сarrier Сodes validation to service layer #131

Closed
@naydav

Description

@naydav

In
https://github.com/magento-engcom/msi/blob/develop/app/code/Magento/Inventory/Controller/Adminhtml/Source/SourceCarrierDataProcessor.php#L67-L70
we have some validation.

But it validation will be run only for saving via the controller. But we need to perform this check in all cases (for example save via REST call)
So need to move this logic to service layer
https://github.com/magento-engcom/msi/blob/develop/app/code/Magento/Inventory/Model/SourceCarrierLinkManagement.php

Also, need to cover this functionality with WebApi tests

During this work, we need to change logic of Integration tests
We need to register new 'carrier codes'(which used in integration tests) in Shipping system

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions