[NFC][SPARC] Fix typos and style mismatches #96019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
|
@llvm/pr-subscribers-backend-sparc @llvm/pr-subscribers-mc Author: Koakuma (koachan) ChangesFix style errors accidentally introduced in PRs #87259 and #94245. Full diff: https://github.com/llvm/llvm-project/pull/96019.diff 3 Files Affected:
diff --git a/llvm/lib/Target/Sparc/SparcInstrAliases.td b/llvm/lib/Target/Sparc/SparcInstrAliases.td
index eedad25737f65..e77b7f5c376bf 100644
--- a/llvm/lib/Target/Sparc/SparcInstrAliases.td
+++ b/llvm/lib/Target/Sparc/SparcInstrAliases.td
@@ -568,7 +568,7 @@ let EmitPriority = 0 in {
// or imm, reg, rd -> or reg, imm, rd
def : InstAlias<"or $simm13, $rs1, $rd", (ORri IntRegs:$rd, IntRegs:$rs1, simm13Op:$simm13)>;
- // addc/addx imm, reg, rd -> or reg, imm, rd
+ // addc/addx imm, reg, rd -> addc/addx reg, imm, rd
def : InstAlias<"addx $simm13, $rs1, $rd", (ADDCri IntRegs:$rd, IntRegs:$rs1, simm13Op:$simm13)>;
}
diff --git a/llvm/test/CodeGen/SPARC/inlineasm.ll b/llvm/test/CodeGen/SPARC/inlineasm.ll
index 9817d7c6971f5..14ea0a2a12602 100644
--- a/llvm/test/CodeGen/SPARC/inlineasm.ll
+++ b/llvm/test/CodeGen/SPARC/inlineasm.ll
@@ -144,7 +144,7 @@ entry:
ret void
}
-; CHECK-label:test_twinword
+; CHECK-LABEL: test_twinword:
; CHECK: rd %asr5, %i1
; CHECK: srlx %i1, 32, %i0
diff --git a/llvm/test/MC/Disassembler/Sparc/sparc-v9.txt b/llvm/test/MC/Disassembler/Sparc/sparc-v9.txt
index d561216fec6f2..9e4ff04841d5a 100644
--- a/llvm/test/MC/Disassembler/Sparc/sparc-v9.txt
+++ b/llvm/test/MC/Disassembler/Sparc/sparc-v9.txt
@@ -193,16 +193,16 @@
0xef 0x6e 0x40 0x1a
# CHECK: done
-0x81,0xf0,0x00,0x00
+0x81 0xf0 0x00 0x00
# CHECK: retry
-0x83,0xf0,0x00,0x00
+0x83 0xf0 0x00 0x00
# CHECK: saved
-0x81,0x88,0x00,0x00
+0x81 0x88 0x00 0x00
# CHECK: restored
-0x83,0x88,0x00,0x00
+0x83 0x88 0x00 0x00
# CHECK: rdpr %fq, %i5
-0xbb,0x53,0xc0,0x00
+0xbb 0x53 0xc0 0x00
|
s-barannikov
approved these changes
Jun 19, 2024
koachan
deleted the
users/koachan/spr/nfcsparc-fix-typos-and-style-mismatches
branch
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
Fix style errors accidentally introduced in PRs llvm#87259 and llvm#94245. Reviewers: rorth, jrtc27, brad0, s-barannikov Reviewed By: s-barannikov Pull Request: llvm#96019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix style errors accidentally introduced in PRs #87259 and #94245.