Skip to content

Revert "Sync with main" #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

gabrielbosio
Copy link
Collaborator

Reverts #2116

Copy link

github-actions bot commented Jun 4, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     25.681 s ±  0.030 s    [User: 24.834 s, System: 0.843 s]
  Range (min … max):   25.660 s … 25.702 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     25.714 s ±  0.004 s    [User: 24.860 s, System: 0.850 s]
  Range (min … max):   25.711 s … 25.717 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.377 s ±  0.037 s    [User: 25.060 s, System: 0.840 s]
  Range (min … max):   14.351 s … 14.404 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.017 s ±  0.024 s    [User: 24.929 s, System: 0.916 s]
  Range (min … max):   14.000 s … 14.035 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.03 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.368 s ±  0.304 s    [User: 38.048 s, System: 1.015 s]
  Range (min … max):   10.153 s … 10.583 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.539 s ±  0.509 s    [User: 37.749 s, System: 1.100 s]
  Range (min … max):   10.179 s … 10.898 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.02 ± 0.06 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.525 s ±  0.439 s    [User: 38.238 s, System: 1.056 s]
  Range (min … max):   10.214 s … 10.835 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.445 s ±  0.086 s    [User: 37.406 s, System: 1.161 s]
  Range (min … max):   10.384 s … 10.507 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.01 ± 0.04 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.318 s ±  0.196 s    [User: 38.436 s, System: 1.060 s]
  Range (min … max):   10.179 s … 10.457 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.267 s ±  0.044 s    [User: 38.287 s, System: 1.133 s]
  Range (min … max):   10.236 s … 10.298 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.00 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.436 s ±  0.286 s    [User: 38.728 s, System: 1.153 s]
  Range (min … max):   10.234 s … 10.638 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.167 s ±  0.043 s    [User: 38.443 s, System: 1.223 s]
  Range (min … max):   10.137 s … 10.197 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.03 ± 0.03 times faster than hyper_threading_main threads: 16


Copy link

github-actions bot commented Jun 4, 2025

Benchmark Results for modified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
head big_factorial 2.164 ± 0.016 2.153 2.206 1.00
Command Mean [s] Min [s] Max [s] Relative
head big_fibonacci 2.099 ± 0.022 2.081 2.144 1.00
Command Mean [s] Min [s] Max [s] Relative
head blake2s_integration_benchmark 7.688 ± 0.042 7.617 7.742 1.00
Command Mean [s] Min [s] Max [s] Relative
head compare_arrays_200000 2.218 ± 0.016 2.198 2.251 1.00
Command Mean [s] Min [s] Max [s] Relative
head dict_integration_benchmark 1.449 ± 0.006 1.438 1.460 1.00
Command Mean [s] Min [s] Max [s] Relative
head field_arithmetic_get_square_benchmark 1.242 ± 0.006 1.233 1.250 1.00
Command Mean [s] Min [s] Max [s] Relative
head integration_builtins 7.711 ± 0.036 7.662 7.772 1.00
Command Mean [s] Min [s] Max [s] Relative
head keccak_integration_benchmark 7.891 ± 0.065 7.818 7.981 1.00
Command Mean [s] Min [s] Max [s] Relative
head linear_search 2.203 ± 0.008 2.190 2.213 1.00
Command Mean [s] Min [s] Max [s] Relative
head math_cmp_and_pow_integration_benchmark 1.537 ± 0.005 1.533 1.549 1.00
Command Mean [s] Min [s] Max [s] Relative
head math_integration_benchmark 1.473 ± 0.010 1.457 1.493 1.00
Command Mean [s] Min [s] Max [s] Relative
head memory_integration_benchmark 1.227 ± 0.003 1.224 1.231 1.00
Command Mean [s] Min [s] Max [s] Relative
head operations_with_data_structures_benchmarks 1.572 ± 0.016 1.549 1.600 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
head pedersen 538.9 ± 2.7 536.6 546.1 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
head poseidon_integration_benchmark 630.3 ± 2.4 626.3 635.0 1.00
Command Mean [s] Min [s] Max [s] Relative
head secp_integration_benchmark 1.859 ± 0.014 1.847 1.886 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
head set_integration_benchmark 635.9 ± 1.5 634.4 639.9 1.00
Command Mean [s] Min [s] Max [s] Relative
head uint256_integration_benchmark 4.357 ± 0.049 4.299 4.475 1.00

@gabrielbosio gabrielbosio merged commit 870fd60 into starkware-development Jun 4, 2025
82 of 91 checks passed
@gabrielbosio gabrielbosio deleted the revert-2116-sync_with_main branch June 4, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant