Sync with main #2116

gabrielbosio · 2025-06-03T19:04:51Z

Sync starkware-development with main to see if CI in #2113 gets fixed.

* avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file

* Add Makefile and requirements.txt to cache key * Don't fetch cairo stwo exclusive programs * Remove empty file * Restrict caching Cairo programs Revert how the Rust workflow uses the Cairo program paths to calculate the cache keys. This change would imply the branch only adds Makefile and requirements.txt to the cache key computation. --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]>

* dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests

* feat: add support for hint accessible scopes update changelog * Update vm/src/hint_processor/hint_processor_definition.rs Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]>

…2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]>

* fix: Add boundary tests for SecpSplitOutOfRange in secp_utils * Update secp_utils.rs * Update CHANGELOG.md * Update secp_utils.rs * remove optimizations * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * empty commit to fix CI --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]>

…2077) * docs: add --run_from_cairo_pie flag usage documentation for Cairo 0 * docs: add --run_from_cairo_pie flag usage documentation for Cairo 1 * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md * Update README.md * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md Co-authored-by: Gabriel Bosio <[email protected]> * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]>

* Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md

* Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature

* Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI

* Update rust.yml * Update rust.yml

* update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow

* Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments

github-actions · 2025-06-03T19:13:21Z

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     25.858 s ±  0.127 s    [User: 25.057 s, System: 0.798 s]
  Range (min … max):   25.768 s … 25.948 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.943 s ±  0.053 s    [User: 24.055 s, System: 0.885 s]
  Range (min … max):   24.906 s … 24.980 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.04 ± 0.01 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.418 s ±  0.053 s    [User: 25.202 s, System: 0.840 s]
  Range (min … max):   14.380 s … 14.456 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.539 s ±  0.004 s    [User: 24.172 s, System: 0.901 s]
  Range (min … max):   13.536 s … 13.541 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.06 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.397 s ±  0.324 s    [User: 37.628 s, System: 1.032 s]
  Range (min … max):   10.168 s … 10.626 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.310 s ±  0.100 s    [User: 36.153 s, System: 1.075 s]
  Range (min … max):   10.239 s … 10.381 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.01 ± 0.03 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.332 s ±  0.036 s    [User: 37.907 s, System: 1.033 s]
  Range (min … max):   10.307 s … 10.358 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.983 s ±  0.070 s    [User: 36.579 s, System: 1.092 s]
  Range (min … max):    9.933 s … 10.032 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.04 ± 0.01 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.316 s ±  0.066 s    [User: 37.807 s, System: 1.060 s]
  Range (min … max):   10.269 s … 10.363 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.941 s ±  0.151 s    [User: 36.793 s, System: 1.094 s]
  Range (min … max):    9.834 s … 10.048 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.04 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.352 s ±  0.144 s    [User: 38.404 s, System: 1.171 s]
  Range (min … max):   10.250 s … 10.454 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.220 s ±  0.184 s    [User: 36.948 s, System: 1.172 s]
  Range (min … max):   10.089 s … 10.350 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 16

github-actions · 2025-06-03T19:14:27Z

Benchmark Results for modified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
`head big_factorial`	2.088 ± 0.026	2.068	2.157	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head big_fibonacci`	2.022 ± 0.010	2.006	2.046	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head blake2s_integration_benchmark`	7.420 ± 0.096	7.312	7.656	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head compare_arrays_200000`	2.134 ± 0.024	2.110	2.198	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head dict_integration_benchmark`	1.391 ± 0.014	1.378	1.430	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head field_arithmetic_get_square_benchmark`	1.212 ± 0.009	1.200	1.231	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head integration_builtins`	7.553 ± 0.157	7.432	7.933	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head keccak_integration_benchmark`	7.590 ± 0.069	7.504	7.724	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head linear_search`	2.121 ± 0.027	2.101	2.193	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head math_cmp_and_pow_integration_benchmark`	1.471 ± 0.004	1.466	1.476	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head math_integration_benchmark`	1.428 ± 0.008	1.420	1.440	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head memory_integration_benchmark`	1.202 ± 0.018	1.186	1.236	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head operations_with_data_structures_benchmarks`	1.510 ± 0.011	1.500	1.534	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`head pedersen`	526.3 ± 4.5	522.0	536.1	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`head poseidon_integration_benchmark`	601.0 ± 4.4	597.1	612.7	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head secp_integration_benchmark`	1.785 ± 0.006	1.777	1.800	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`head set_integration_benchmark`	667.0 ± 7.5	657.5	682.2	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`head uint256_integration_benchmark`	4.167 ± 0.022	4.132	4.193	1.00

codecov · 2025-06-03T19:30:16Z

Codecov Report

Attention: Patch coverage is 98.61751% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.67%. Comparing base (b818326) to head (106846b).
Report is 1 commits behind head on starkware-development.

Files with missing lines	Patch %	Lines
cairo-vm-tracer/src/tracer.rs	0.00%	1 Missing ⚠️
cairo-vm-tracer/src/tracer_data.rs	0.00%	1 Missing ⚠️
vm/src/vm/vm_memory/memory.rs	96.00%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##           starkware-development    #2116      +/-   ##
=========================================================
- Coverage                  96.76%   96.67%   -0.09%     
=========================================================
  Files                        104      104              
  Lines                      45641    43969    -1672     
=========================================================
- Hits                       44164    42508    -1656     
+ Misses                      1477     1461      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JulianGCalderon

LGTM

This reverts commit 7269a8f.

FrancoGiachetta and others added 15 commits April 8, 2025 22:07

Remove duplicated get_val (#2065)

6b283d7

* avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file

dev: make Memory::get pub (#2039)

7ba282c

* dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests

feat: add support for alias identifiers destination in program serde (#…

4535c8f

…2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]>

Fix WRITE_DIVMOD_SEGMENT hint (#2078)

10b3dd9

* Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md

Prepare for Release v3.0.0-rc.1 (#2092)

b11ad82

* Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI

fix: correct cache keys for no-std test coverage in CI (#2093)

83e6e32

* Update rust.yml * Update rust.yml

Update rust toolchain to 1.87.0 (#2100)

e339ab7

* update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow

fix Changelog link (#2104)

2204910

Improve memory_segments coverage (#2110)

4f02f5a

* Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments

Merge branch 'main' into sync_with_main

106846b

gabrielbosio marked this pull request as ready for review June 4, 2025 20:40

JulianGCalderon approved these changes Jun 4, 2025

View reviewed changes

gabrielbosio merged commit 7269a8f into starkware-development Jun 4, 2025
94 checks passed

gabrielbosio deleted the sync_with_main branch June 4, 2025 21:08

gabrielbosio added a commit that referenced this pull request Jun 4, 2025

Revert "Sync with main (#2116)"

95505e9

This reverts commit 7269a8f.

gabrielbosio mentioned this pull request Jun 4, 2025

Revert "Sync with main" #2117

Merged

gabrielbosio added a commit that referenced this pull request Jun 4, 2025

Revert "Sync with main (#2116)" (#2117)

870fd60

This reverts commit 7269a8f.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sync with main #2116

Sync with main #2116

Uh oh!

gabrielbosio commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

codecov bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

JulianGCalderon left a comment

Uh oh!

Uh oh!

Uh oh!

Sync with main #2116

Sync with main #2116

Uh oh!

Conversation

gabrielbosio commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

codecov bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JulianGCalderon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 3, 2025 •

edited

Loading