Skip to content

[SYCL] Free functions and dynamic linking fixes for CUDA/HIP #17899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 11, 2025
Merged

[SYCL] Free functions and dynamic linking fixes for CUDA/HIP #17899

merged 6 commits into from
Apr 11, 2025

Conversation

jchlanda
Copy link
Contributor

@jchlanda jchlanda commented Apr 8, 2025

No description provided.

@jchlanda jchlanda requested review from a team as code owners April 8, 2025 07:22
@jchlanda jchlanda requested review from EwanC and cperkinsintel April 8, 2025 07:22
@jchlanda
Copy link
Contributor Author

jchlanda commented Apr 8, 2025

This is a follow up to: #17742

@jchlanda
Copy link
Contributor Author

jchlanda commented Apr 8, 2025

Fixes: #16004
Fixes: #15742
Fixes: #5213

EwanC
EwanC reviewed Apr 8, 2025
View reviewed changes
sycl/test-e2e/Graph/Explicit/free_function_kernels.cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be worth checking in Graph/Update/FreeFunctionKernels for other tests to re-enable. I think most (all?) of them have this cuda xfail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap will re-enable them, saw them passing in a CI run here: https://github.com/intel/llvm/actions/runs/14327574541/job/40157100672?pr=17899#step:17:2858

@jchlanda jchlanda mentioned this pull request Apr 9, 2025
Closed
@jchlanda
Copy link
Contributor Author

@intel/dpcpp-tools-reviewers could you please have a look at this patch?

asudarsa
asudarsa approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. Just one nit.

Thanks

@jchlanda
Copy link
Contributor Author

@intel/llvm-gatekeepers this should be ready to go.

Thank you.

@martygrant martygrant merged commit fc328cc into intel:sycl Apr 11, 2025
24 checks passed
@jchlanda jchlanda mentioned this pull request Apr 14, 2025
Closed
npmiller added a commit to npmiller/llvm that referenced this pull request Apr 23, 2025
@npmiller
[SYCL] Remove unsupported on new offload driver test
c979192 
This test was fixed by:
* intel#17899
* intel#18000

Fixes intel#17812
@npmiller npmiller mentioned this pull request Apr 23, 2025
Merged
aelovikov-intel pushed a commit that referenced this pull request Apr 28, 2025
@npmiller
[SYCL] Remove unsupported on new offload driver test (#18151)
2c3e5ef 
This test was fixed by:
* #17899
* #18000

Fixes #17812
@npmiller npmiller mentioned this pull request May 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@asudarsa asudarsa asudarsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jchlanda @EwanC @cperkinsintel @asudarsa @martygrant