Skip to content

[SYCL] [E2E] Fix free funcs tests #17742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Conversation

jchlanda
Copy link
Contributor

This patch:

  • enables free function tests
  • re-writes them in terms of sycl::ext::oneapi::this_work_item (instead of, now deprecated, sycl::ext::oneapi::experimental::this_id and friends)
  • fixes build failure caused by the removal of core_sg_supported
  • removes a test from free_function_queries.cpp as it was only checking correct translation between old and new spelling of the extension

@jchlanda jchlanda requested a review from a team as a code owner March 31, 2025 13:51
@jchlanda jchlanda requested a review from slawekptak March 31, 2025 13:51
@jchlanda jchlanda closed this Mar 31, 2025
@jchlanda jchlanda reopened this Mar 31, 2025
@jchlanda
Copy link
Contributor Author

jchlanda commented Apr 3, 2025

Friendly ping @slawekptak

@jchlanda
Copy link
Contributor Author

jchlanda commented Apr 7, 2025

Would you like me to do anything else for this patch @slawekp, @intel/llvm-reviewers-runtime? Thank you.

@jchlanda jchlanda closed this Apr 9, 2025
@jchlanda jchlanda reopened this Apr 9, 2025
@jchlanda
Copy link
Contributor Author

jchlanda commented Apr 9, 2025

@intel/llvm-gatekeepers this should be ready to roll.

Thank you.

@kbenzie kbenzie merged commit cb5ef36 into intel:sycl Apr 9, 2025
60 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants