-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] [E2E] Fix free funcs tests #17742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ce004d
to
1e6e605
Compare
1e6e605
to
1c25631
Compare
Friendly ping @slawekptak |
Would you like me to do anything else for this patch @slawekp, @intel/llvm-reviewers-runtime? Thank you. |
1c25631
to
460d07f
Compare
cperkinsintel
approved these changes
Apr 8, 2025
@intel/llvm-gatekeepers this should be ready to roll. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
sycl::ext::oneapi::this_work_item
(instead of, now deprecated,sycl::ext::oneapi::experimental::this_id
and friends)core_sg_supported
free_function_queries.cpp
as it was only checking correct translation between old and new spelling of the extension