Generate types from the metamodel (attempt 2) #478
Conversation
|
I'm also considering moving to |
|
Of interest to @thomasjm and @joyfulmantis perhaps. |
| pure $ parens $ "Row.Rec" <+> tyList | ||
|
|
||
| genEnum :: Enumeration -> CodeGenM T.Text | ||
| genEnum e@Enumeration{name} = do |
There was a problem hiding this comment.
The gen functions (genStruct, genEnum, genAlias) are basically identical. Would it be better for them to be refactored into one function?
There was a problem hiding this comment.
They do have a lot in common, but they also have a lot that's different and the input functions are different. I think to share more I'd have to introduce an abstraction for all the pieces of a Haskell datatype, which I think would in itself be quite complicated...
|
Addressed comments, and added |
|
Possible dumb question--I wanted to build the Haddocks for this but ran into trouble. I added a simple Stack file (see below) and was able to build the branch. However, when I run # stack.yaml
resolver: lts-19.33
packages:
- lsp-types
extra-deps:
- row-types-1.0.1.2 |
|
Hmm, it works for me with |
Hopefully this makes it either to port hls to the new release
| -- | Response error type as defined in the spec. | ||
| data ResponseError = | ||
| ResponseError | ||
| { _code :: ErrorCodes |
There was a problem hiding this comment.
ResponseError takes ErrorCodes, but you have two types of error codes: ErrorCodes and LSPErrorCodes.
There was a problem hiding this comment.
I don't really know what to do here: the metamodel is weird. They both define some error codes, of which I guess any can be used, but it's not explicitly represented as a type... I guess we could use ErrorCodes |? LSPErrorCodes :/
There was a problem hiding this comment.
I think we will need to do that, as otherwise, the LSPErrorCodes become useless (and some of them are useful and used in the code)
Co-authored-by: Michael Peyton Jones <[email protected]>
…eerrors Replace some TResponseError with ResponseError
Separate lens module, Have ResponseErrors also take LSPResponseErrors, and standardize SemanticToken fields
|
Okay, let's merge this to make iteration easier. It looks like the upgrade in HLS is going okay, so I don't think we'll need to back this out and we can tweak it in master. |
|
I've been converting my projects to |
|
Hooray, I'm glad it's good to use :) |
|
Stoked with the quality of this lib! It's making development of the Excited to have access to new LSP features quickly 🙌🏼 Thanks for all your hard work! |
| return len | ||
|
|
||
| contentType = do | ||
| _ <- string "Content-Type: " |
There was a problem hiding this comment.
Argh, not sure how that happened. will fix
This is a redone version of #458. That foundered on the use of TH, in particular I really struggled to get it to work on multiple versions of GHC. This version is similar, but takes a much more basic approach of just building up big strings for Haskell modules. It works okay; it's much easier to debug; it's more reliable; documentation works better; and it compiles faster. So I think we can go with this.