Skip to content

Replace some TResponseError with ResponseError #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joyfulmantis
Copy link
Collaborator

This a surgical edit to replace some of the TResponseErrors with ResponseErrors, making it easier to port HLS to the new release. This is one of the possible permanent solutions moving forward. Other possible options are:

  • Keeping the TResponseMessage as is and creating another type in between TResponseMessage and ResponseMessage.
  • Implementing these changes at the same time as also creating a new fully typed ResponseMessage.
  • Refactoring HLS to use TResponseErrors (I feel it should be possible, but will need someone more familiar with Haskell type magic than I am).

Hopefully this makes it either to port hls to the new release
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks fine to me!

Co-authored-by: Michael Peyton Jones <[email protected]>
@michaelpj michaelpj merged commit 9636cf0 into haskell:mpj/metamodel2 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants