-
-
Notifications
You must be signed in to change notification settings - Fork 391
Fix #2612 - hlint plugin - Apply fixities to parsed source before sending to apply-refact #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
911d10f
fix #2612. apply fixities to parsed source before sent to apply-refact
eddiemundo 99c7478
Merge branch 'master' of https://github.com/haskell/haskell-language-…
eddiemundo f623b82
fix tests
eddiemundo db9ecda
dont hardcode getApplyHintText
eddiemundo 7530560
try and fix pedantic warning
eddiemundo 6ca0ba8
Merge branch 'master' of https://github.com/haskell/haskell-language-…
eddiemundo 0f59093
fix cpp
eddiemundo 1c247fc
fix cpp 2
eddiemundo ecf0959
actually fix pendantic warnings because import is not used when hlint…
eddiemundo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
plugins/hls-hlint-plugin/test/testdata/RightToLeftFixities.expected.hs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module RightToLeftFixities where | ||
import Data.List (sortOn) | ||
import Control.Arrow ((&&&)) | ||
import Data.Ord (Down(Down)) | ||
functionB :: [String] -> [(Char,Int)] | ||
functionB = sortOn (Down . snd) . map (head &&& length) . id |
6 changes: 6 additions & 0 deletions
6
plugins/hls-hlint-plugin/test/testdata/RightToLeftFixities.hs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module RightToLeftFixities where | ||
import Data.List (sortOn) | ||
import Control.Arrow ((&&&)) | ||
import Data.Ord (Down(Down)) | ||
functionB :: [String] -> [(Char,Int)] | ||
functionB = reverse . sortOn snd . map (head &&& length) . id |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.