Fix #2612 - hlint plugin - Apply fixities to parsed source before sending to apply-refact #2624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we weren't applying the standard fixities to the parsed source before handing it over to
applyRefactorings'
. Standalone hlint works because it calls the refactor executable which does apply the fixities before doing the refactor.This also fixes a class of issues where applying the hlint refactor does nothing.
Closed the previous PR because I rebased wrong.