feat: support https push #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alocquet
force-pushed
the
feature/support-https-push
branch
from
ab827cf to
6c64db2
Compare
extrawurst
requested changes
Oct 19, 2020
There was a problem hiding this comment.
Hey @alocquet thanks for working on this❤️! I have made some comments
This was referenced Oct 19, 2020
alocquet
force-pushed
the
feature/support-https-push
branch
from
53541f3 to
2db713b
Compare
extrawurst
reviewed
Oct 20, 2020
alocquet
force-pushed
the
feature/support-https-push
branch
from
9a9f004 to
ec876e1
Compare
extrawurst
approved these changes
Oct 20, 2020
|
@alocquet sorry it takes me so long to get this merged. I hope to have time tomorrow to give it a spin and then merge 🙈 |
|
Don't worry :) |
|
Awesome! Works for me. Just gave it a spin! Thanks for working on this❤️! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #344
Finally, I use git2 credential help and I retrieve username/password from :
I show username textbox only if I can't retrieve it. I clean credentials after push to avoid keeping it in memory.