Push fails with username not found.

[edfloreshz]

Pushing to a repository fails
I made a small modification to a file to test gitui, after I made a commit and tried to push I got a backtrace error.

To Reproduce
Steps to reproduce the behavior:

1. Modify a file
2. Commit (or don't, happens either way)
3. Push
4. See the error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Context (please complete the following information):

• Arch Linux
• GitUI Version [0.10.1]
• Rust version: [1.46]

Additional context
I don't know if this is an in-progress feature, if it is, feel free to close the issue.

[extrawurst]

Yeah pushing is indeed in-progress but either way an easy way to keep it from crashing is to use the methods we already use to show errors in other places (example: #108)

but the question is: do you actually have not username defined ?

[edfloreshz]

If by having a username defined you mean having it on git config, then yes. In case there's an internal git credentials keychain in gitui, then no.

Do you mind if I try to handle the UB in this issue? Might be a good way to start contributing to your project for the first time 🧑🏻‍💻.

[extrawurst]

Sure take it :)
Yeah I mean the gitconfig, gitui does not handle user credentials directly.

BTW. this is no undefined behaviour - its a very well defined panic :P

[edfloreshz]

Oh okay, sorry, handle the crash then 👍
Thank you!

[edfloreshz]

@extrawurst Unrelated to this issue, I have a question.
Is the push option supposed to be available even when no commit has been made?

[extrawurst]

Is the push option supposed to be available even when no commit has been made?

actually no, it could be shown in a disabled state. but let's create another issue for that

[extrawurst]

fixed in #305

[extrawurst]

@edfloreshz do you mind looking into #353 to see if this allows you to push to the repo in question?

[edfloreshz]

This fixes the issue for me!

As a suggestion, it would be nice to display an Everything up-to-date message when trying to push without new changes, at least until the push option becomes disabled when no new changes are present in the repo.