Skip to content

feat(browser): Add DOMException.code as tag if it exists #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2020
Merged

feat(browser): Add DOMException.code as tag if it exists #3018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18277ed
add code as tag
lobsterkatie Oct 29, 2020
9ddea3e
Update packages/browser/src/eventbuilder.ts
kamilogorek Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/browser/src/eventbuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export function eventFromUnknownInput(
}
if (isDOMError(exception as DOMError) || isDOMException(exception as DOMException)) {
// If it is a DOMError or DOMException (which are legacy APIs, but still supported in some browsers)
// then we just extract the name and message, as they don't provide anything else
// then we just extract the name, code, and message, as they don't provide anything else
// https://developer.mozilla.org/en-US/docs/Web/API/DOMError
// https://developer.mozilla.org/en-US/docs/Web/API/DOMException
const domException = exception as DOMException;
Expand All @@ -87,6 +87,10 @@ export function eventFromUnknownInput(

event = eventFromString(message, syntheticException, options);
addExceptionTypeValue(event, message);
if ('code' in domException) {
event.tags = { ...event.tags, 'DOMException.code': `${domException.code}` }
}

return event;
}
if (isError(exception as Error)) {
Expand Down