feat(browser): Add DOMException.code as tag if it exists
#3018
Conversation
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-add-code-to-domexception
branch
from
d7839ce to
18277ed
Compare
lobsterkatie
changed the title
DOMException.code to event message if .name is undefinedDOMException.code as tag if it exists
packages/browser/src/eventbuilder.ts
Outdated
| @@ -87,6 +87,8 @@ export function eventFromUnknownInput( | |||
|
|
|||
| event = eventFromString(message, syntheticException, options); | |||
| addExceptionTypeValue(event, message); | |||
| event.tags = domException.code ? { ...event.tags, 'DOMException.code': String(domException.code) } : event.tags; | |||
There was a problem hiding this comment.
eventFromString has no way to add any tags to the event itself, so this fallback will always produce an event with malformed tags:
const event = {}
console.log(event) // {}
event.tags = event.tags
console.log(event) // {tags:undefined}Also code can be 0 for some custom types, which will omit this, as they are using integers, not strings.
There was a problem hiding this comment.
Ah, good catch. Thanks.
packages/browser/src/eventbuilder.ts
Outdated
| @@ -87,6 +87,8 @@ export function eventFromUnknownInput( | |||
|
|
|||
| event = eventFromString(message, syntheticException, options); | |||
| addExceptionTypeValue(event, message); | |||
| event.tags = domException.code ? { ...event.tags, 'DOMException.code': String(domException.code) } : event.tags; | |||
There was a problem hiding this comment.
| event.tags = domException.code ? { ...event.tags, 'DOMException.code': String(domException.code) } : event.tags; | |
| if ('code' in domException) { | |
| event.tags = { ...event.tags, 'DOMException.code': `${domException.code}` } | |
| } |
There was a problem hiding this comment.
I left the "old" tags, just in case we ever decided to for example mark events as being produced by eventFromString or something. Keep in mind that its safe to destructure undefined values, see:
https://github.com/tc39/proposal-object-rest-spread/blob/master/Spread.md
Null/Undefined Are Ignored
There was a problem hiding this comment.
Wait, I'm confused. I did, too...
Though
DOMException.codeis long since deprecated in favor ofDOMException.name, there are apparently still cases where it shows up. This adds the code as a tag in those cases.Fixes #3005.