Clean up ApiGenerator #3755
Merged
Clean up ApiGenerator #3755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds for preferred HTTP methods
now we only yield methods for the preferred HTTP method
codebrain
reviewed
May 27, 2019
| endpoint.MethodName = tokens.Last(); | ||
| if (tokens.Length > 1) | ||
| endpoint.Namespace = tokens[0]; | ||
| //todo side effect |
codebrain
reviewed
May 27, 2019
| MergeArrayHandling = MergeArrayHandling.Union | ||
| }); | ||
|
|
||
| if (pathsOverride != null) original.SelectToken("*.url.paths").Replace(pathsOverride); |
There was a problem hiding this comment.
👍 simplifies the .replace.json files...
codebrain
approved these changes
May 27, 2019
| } | ||
| @if (names.DescriptorNotFoundInCodebase) | ||
| {<text> | ||
| //TODO THIS METHOD IS UNMAPPED! |
There was a problem hiding this comment.
I've always wondered if we ought to introduce a deliberate compiler error here instead, to prompt us to do the right thing and fix it.... thoughts?
There was a problem hiding this comment.
++ 💯 I want to generate these into Unmapped.Requests|Response.<MethodName>.cs where we generate stubs for Request and Response with obsoletes with compiler errors on them.
This makes adding a new API easier and makes sure we won't release a stub.
| </text> | ||
| } | ||
| @if (names.DescriptorNotFoundInCodebase) | ||
| {<text> //TODO THIS METHOD IS UNMAPPED! Expected to find @names.DescriptorName and @names.RequestName in a file called @(names.RequestName).cs in NEST's codebase |
There was a problem hiding this comment.
Introduce a deliberate compiler error here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the ApiGenerator a tad. One of the oldest parts of the codebase dating back to
1.0The razor views can now be split using partials and they use more dedicated models for each individual component. In the past everything was driven by
CsharpMethodnow request/interfaces/et all have specific domain models.The generated files are now also automatically indented so we need to fiddle a whole lot less with whitespace in the razor views.
We no longer generate alternative http methods on the low level client so things such as
client.SearchGet()are a thing of the past.This PR also serves as jumping point for introducing namespaces and the domain model should help massively when we want to reimplement the yaml test runner next.