Generate API paths without leading forward slash #3700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the API generator to trim the leading forward slashes from all API paths. When the base URI with which the API path will be combined also contains a relative path, the relative path should be respected in the combined URI output. Fixes #3691
Mpdreamz
approved these changes
Apr 29, 2019
Mpdreamz
added a commit
that referenced
this pull request
May 20, 2019
Mpdreamz
added a commit
that referenced
this pull request
May 28, 2019
* Update code configuration for low level client to only generate methods for preferred HTTP methods * Fixed locations to be nix friendly * Removed alternative HTTP method named methods in the low level client * progress commit * Simplified CsharpMethodsWithQueryString now we only yield methods for the preferred HTTP method * progress commit * progress commit * can now use partials/include this should start cleaning up the cshtml files * Able to introduce partial methods now * Add partial views * RequestDescriptorBase separate view * moved descriptors to partials (initial stab) * reindent generated code automatically * Split name and namespace * Request/Descriptors are no longer backed by CsharpMethods * start cleaning up CsharpMethod * PatchMethod on overrides is gone, * Cleaned up code configuration a tad * deduplication is now gone, marked aliases that were duplicate as deprecated * In case of GET, OTHER prefer OTHER * rebased against 7.x and reworked replace files into patch files * skip params also on requestparameters and prefer plural source_includes * reapply fix from #3700 to make sure virtual paths as root are supported again
Mpdreamz
added a commit
that referenced
this pull request
May 28, 2019
* Update code configuration for low level client to only generate methods for preferred HTTP methods * Fixed locations to be nix friendly * Removed alternative HTTP method named methods in the low level client * progress commit * Simplified CsharpMethodsWithQueryString now we only yield methods for the preferred HTTP method * progress commit * progress commit * can now use partials/include this should start cleaning up the cshtml files * Able to introduce partial methods now * Add partial views * RequestDescriptorBase separate view * moved descriptors to partials (initial stab) * reindent generated code automatically * Split name and namespace * Request/Descriptors are no longer backed by CsharpMethods * start cleaning up CsharpMethod * PatchMethod on overrides is gone, * Cleaned up code configuration a tad * deduplication is now gone, marked aliases that were duplicate as deprecated * In case of GET, OTHER prefer OTHER * rebased against 7.x and reworked replace files into patch files * skip params also on requestparameters and prefer plural source_includes * reapply fix from #3700 to make sure virtual paths as root are supported again * moved lowlevel client method into partial * Moved methods to partials and no longer yield an async version, let the views handle that * make sure ctx is passed correctly in async variants * Low level client now has namespaces! * ContentType now wired per namespace, cat only in this case * started on generating the high level client methods as well * status commit requestparameters are now per namespace too and introduce an actual namespace * Continued working on making sure the methods on the highlevel client are generated and namespaced * progress commit * All methods are now generated * Tests now uses namespaced methods * progress commit * things compile again * remove some compiler warnings * Found a way for cshtml to not report errors * things compile again * The generation of methods is now much more controlled Introduced dedicated views and view models and we are reusing a whole lot more: * Add support for marking request so that the generated methods take TDocument * Fix up tests now that custom constructors are automatically wired up * requestparameters dependentupon, still now working * Clean up files and codegenerator routines a tad * Renamed final bits * generators now in separate files * update namespaces in ApiGenerator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the API generator to trim the leading forward slashes from all API paths. When the base URI with which the API path will be combined also contains a relative path, the relative path should be respected in the combined URI output.
Fixes #3691