Skip to content

fix: dont capture IO for docker pass-through commands #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: dont capture IO for docker pass-through commands #514

wants to merge 1 commit into from

Conversation

miki725
Copy link
Collaborator

@miki725 miki725 commented May 15, 2025 •
edited
Loading

Issue

docker save <image> for larger images errored due to OOM

Description

pass through was using a runCommand wrapper which ended up capturing all of the output which would increase memory usage hence OOM error

Testing

docker save <large-image>

@miki725 miki725 requested a review from viega as a code owner May 15, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viega viega Awaiting requested review from viega viega is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miki725