Skip to content

Commit a804f6c

Browse files
committed
fix: dont capture IO for docker pass-through commands
1 parent ac7dea8 commit a804f6c

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
# Chalk Release Notes
22

3+
## On the `main` branch
4+
5+
### Fixes
6+
7+
- Docker pass-through commands (non build/push) commands were capturing all
8+
IO which could possibly fail with OOM. Standard in/out is no longer captured
9+
for pass-through commands to resolve that.
10+
([#514](https://github.com/crashappsec/chalk/pull/514))
11+
312
## 0.5.6
413

514
**Apr 30, 2025**

chalk.nimble

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ bin = @["chalk"]
1111

1212
# Dependencies
1313
requires "nim >= 2.0.8"
14-
requires "https://github.com/crashappsec/con4m#0487d36db4432a800138d4f69ee94bc98d881493"
14+
requires "https://github.com/crashappsec/con4m#8faa1db2b2e591814a5114f152c81cd51e5ea90f"
1515
requires "https://github.com/viega/zippy == 0.10.7" # MIT
1616
requires "https://github.com/NimParsers/parsetoml == 0.7.1" # MIT
1717

src/util.nim

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -250,12 +250,7 @@ proc runCmdNoOutputCapture*(exe: string,
250250
newStdIn = ""): int {.discardable.} =
251251
let execOutput = runCmdGetEverything(exe, args, newStdIn,
252252
passthrough = true,
253-
timeoutUsec = 0) # No timeout
254-
result = execOutput.getExit()
255-
256-
proc runCmdExitCode*(exe: string, args: seq[string]): int {.discardable } =
257-
let execOutput = runCmdGetEverything(exe, args,
258-
passthrough = false,
253+
capture = SPIoNone,
259254
timeoutUsec = 0) # No timeout
260255
result = execOutput.getExit()
261256

0 commit comments

Comments
 (0)