Skip to content

feat(s3): Custom Properties for AWS #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(s3): Custom Properties for AWS #44

wants to merge 2 commits into from

Conversation

mfranceschit
Copy link
Contributor

Issue tracker links

CG-1005

Changes/solution

  • It uses the serviceProperties to store configurable properties per service.
  • Set S3 listObjects limit using the MaxKeys property.

@mfranceschit mfranceschit self-assigned this Apr 20, 2022
@mfranceschit mfranceschit mentioned this pull request Apr 20, 2022
Open
hjaraujof
hjaraujof approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@hjaraujof hjaraujof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjaraujof hjaraujof hjaraujof approved these changes

@csbrandt csbrandt Awaiting requested review from csbrandt

@tyler-dunkel tyler-dunkel Awaiting requested review from tyler-dunkel

@m-pizarro m-pizarro Awaiting requested review from m-pizarro

Assignees

@mfranceschit mfranceschit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranceschit @hjaraujof