feat: Set onfigurable limit for s3 list objects

Author: Marco Franceschi

src/services/s3/data.ts

@@ -394,8 +394,11 @@ const getBucketAdditionalInfo = async (s3: S3, name: BucketName) =>
     })
   })
 
-const listBucketsForRegion = async (s3: S3, resolveRegion: () => void) =>
-  new Promise<{ buckets: Bucket[]; ownerId: Owner }>(resolve => {
+const listBucketsForRegion = async (
+  s3: S3,
+  resolveRegion: () => void
+): Promise<{ buckets: Bucket[]; ownerId: Owner }> =>
+  new Promise(resolve => {
     s3.listBuckets((err: AWSError, data: ListBucketsOutput) => {
       /**
        * No Data for the region
@@ -424,16 +427,20 @@ const listBucketsForRegion = async (s3: S3, resolveRegion: () => void) =>
     })
   })
 
-const listBucketObjects = async (s3: S3, name: BucketName) =>
-  new Promise<S3Object[]>(resolve => {
+const listBucketObjects = async (
+  s3: S3,
+  name: BucketName,
+  params?: { [field: string]: any }
+): Promise<S3Object[]> =>
+  new Promise(resolve => {
     const contents: S3Object[] = []
     /**
      * S3 Buckets can get quite large, so we limit the total number
      * Of objects returned per bucket to 1000
      */
     const opts: any = {
       Bucket: name,
-      MaxKeys: awsBucketItemsLimit,
+      ...(params ?? { MaxKeys: awsBucketItemsLimit }),
     }
     const listAllObjects = (token?: string) => {
       if (token) {
@@ -495,9 +502,11 @@ export interface RawAwsS3 {
 export default async ({
   regions,
   config,
+  params,
 }: {
   regions: string
   config: Config
+  params: any
 }): Promise<{
   [region: string]: RawAwsS3[]
 }> =>
@@ -552,7 +561,11 @@ export default async ({
           s3ForcePathStyle: true,
         })
         logger.debug(lt.gettingBucketBasicInfo(Name))
-        const bucketObjectList: S3Object[] = await listBucketObjects(s3, Name)
+        const bucketObjectList: S3Object[] = await listBucketObjects(
+          s3,
+          Name,
+          params
+        )
 
         bucketData[idx].Contents = []
         if (!isEmpty(bucketObjectList)) {

src/types/generated.ts

@@ -4212,8 +4212,12 @@ export type AwsTransitGateway = AwsBaseService & {
   vpnEcmpSupport?: Maybe<Scalars['String']>;
 };
 
-export type AwsTransitGatewayAttachment = AwsBaseService & {
+export type AwsTransitGatewayAttachment = {
+  accountId: Scalars['String'];
+  arn: Scalars['String'];
   creationTime?: Maybe<Scalars['String']>;
+  id: Scalars['String'];
+  region?: Maybe<Scalars['String']>;
   resourceId?: Maybe<Scalars['String']>;
   resourceOwnerId?: Maybe<Scalars['String']>;
   resourceType?: Maybe<Scalars['String']>;