-
Notifications
You must be signed in to change notification settings - Fork 147
feat: Adding New Parameters #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CoshUS
merged 6 commits into
aws:dependency-parameters
from
CoshUS:feat/dependency-parameters
Aug 27, 2021
Merged
feat: Adding New Parameters #263
CoshUS
merged 6 commits into
aws:dependency-parameters
from
CoshUS:feat/dependency-parameters
Aug 27, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingchm
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mingkun2020
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CoshUS
added a commit
to CoshUS/aws-lambda-builders
that referenced
this pull request
Sep 2, 2021
commit 4edd68a Author: Cosh_ <[email protected]> Date: Thu Sep 2 00:36:08 2021 -0700 Revert "feat: Java Dependency Dir (aws#264)" (aws#273) This reverts commit df2dfeb. commit df2dfeb Author: Cosh_ <[email protected]> Date: Wed Sep 1 16:39:04 2021 -0700 feat: Java Dependency Dir (aws#264) * Added New Parameters * Formatted with Black * Adding New Java Gradle Action * Updated dependencies_folder to dependencies_dir * Added JavaCopyDependenciesAction * Refactoring Java Tests * Updated Java OSUtil Import * Fixed Unit Tests * Updated Java Gradle Integration Tests * Added Deps Dir Java Integration Tests * Fixed Unit Tests and Formatted with Black * Fixed Java Integration for Python 2 * Addded JSON RPC Parameters * Added Dependency Parameters to Functional Tests * Removed Unused Import * Fixed Unit Test Join Import commit 80c2982 Author: Cosh_ <[email protected]> Date: Fri Aug 27 16:36:18 2021 -0700 feat: Adding New Parameters (aws#263) * Added New Parameters * Formatted with Black * Updated dependencies_folder to dependencies_dir * Addded JSON RPC Parameters * Added Dependency Parameters to Functional Tests commit 880a9fd Author: Sriram Madapusi Vasudevan <[email protected]> Date: Wed Aug 25 13:42:15 2021 -0700 fix(go version parts): remove alphabets from the version for validation (aws#259) * fix(go version parts): remove alphabets from the version for validation - Go versions like 1.12rc1 or 1.16beta1 are supported. - Test added. * fix: use regex for go versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.