fix(go version parts): remove alphabets from the version for validation #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfuss
approved these changes
Aug 4, 2021
mgrandis
suggested changes
Aug 5, 2021
- Go versions like 1.12rc1 or 1.16beta1 are supported. - Test added.
sriram-mv
force-pushed
the
go_validator
branch
from
caa0072 to
54431c9
Compare
mgrandis
reviewed
Aug 25, 2021
sriram-mv
force-pushed
the
go_validator
branch
from
54431c9 to
0a2c1b0
Compare
mgrandis
approved these changes
Aug 25, 2021
sriram-mv
force-pushed
the
go_validator
branch
from
0a2c1b0 to
9368fda
Compare
sriram-mv
added a commit
that referenced
this pull request
Aug 31, 2021
* fix: improve support for pep517 builds (#265) * A pep517 build can declare build dependencies. Pip will then know to install these dependencies before trying to build a wheel file. * When creating a build environment, it's only guaranteed to last for the duration of the build process. It's not accessible once a pip command finishes running. * When we try to retrieve the version of a package we run a "modified" form of "python setup.py egg_info". * The problem with this is that we're not using the build environment that has all the build dependencies installed (it's already gone), so if setup.py imports a module (e.g. cython) because it expects it to be there because it declared it as a build dependency the egg_info command will fail. * We don't check the RC or have a fallback case if we can't generate egg info. * We fail with an indecipherable IndexError. We now have a fallback where if we can't import/run the setup.py file, we assume the PKG-INFO file should be in the top level directory of the sdist so we check if it's there, and if so we use that file. * Fixed Unit Test Requiring "test" Binary (#266) * fix(go version parts): remove alphabets from the version for validation (#259) * fix(go version parts): remove alphabets from the version for validation - Go versions like 1.12rc1 or 1.16beta1 are supported. - Test added. * fix: use regex for go versions * chore: aws lambda builders version set to 1.7.0 (#269) Co-authored-by: Cosh_ <[email protected]>
CoshUS
added a commit
to CoshUS/aws-lambda-builders
that referenced
this pull request
Sep 2, 2021
commit 4edd68a Author: Cosh_ <[email protected]> Date: Thu Sep 2 00:36:08 2021 -0700 Revert "feat: Java Dependency Dir (aws#264)" (aws#273) This reverts commit df2dfeb. commit df2dfeb Author: Cosh_ <[email protected]> Date: Wed Sep 1 16:39:04 2021 -0700 feat: Java Dependency Dir (aws#264) * Added New Parameters * Formatted with Black * Adding New Java Gradle Action * Updated dependencies_folder to dependencies_dir * Added JavaCopyDependenciesAction * Refactoring Java Tests * Updated Java OSUtil Import * Fixed Unit Tests * Updated Java Gradle Integration Tests * Added Deps Dir Java Integration Tests * Fixed Unit Tests and Formatted with Black * Fixed Java Integration for Python 2 * Addded JSON RPC Parameters * Added Dependency Parameters to Functional Tests * Removed Unused Import * Fixed Unit Test Join Import commit 80c2982 Author: Cosh_ <[email protected]> Date: Fri Aug 27 16:36:18 2021 -0700 feat: Adding New Parameters (aws#263) * Added New Parameters * Formatted with Black * Updated dependencies_folder to dependencies_dir * Addded JSON RPC Parameters * Added Dependency Parameters to Functional Tests commit 880a9fd Author: Sriram Madapusi Vasudevan <[email protected]> Date: Wed Aug 25 13:42:15 2021 -0700 fix(go version parts): remove alphabets from the version for validation (aws#259) * fix(go version parts): remove alphabets from the version for validation - Go versions like 1.12rc1 or 1.16beta1 are supported. - Test added. * fix: use regex for go versions
mndeveci
added a commit
that referenced
this pull request
Sep 29, 2021
* fix: improve support for pep517 builds (#265) * A pep517 build can declare build dependencies. Pip will then know to install these dependencies before trying to build a wheel file. * When creating a build environment, it's only guaranteed to last for the duration of the build process. It's not accessible once a pip command finishes running. * When we try to retrieve the version of a package we run a "modified" form of "python setup.py egg_info". * The problem with this is that we're not using the build environment that has all the build dependencies installed (it's already gone), so if setup.py imports a module (e.g. cython) because it expects it to be there because it declared it as a build dependency the egg_info command will fail. * We don't check the RC or have a fallback case if we can't generate egg info. * We fail with an indecipherable IndexError. We now have a fallback where if we can't import/run the setup.py file, we assume the PKG-INFO file should be in the top level directory of the sdist so we check if it's there, and if so we use that file. * Fixed Unit Test Requiring "test" Binary (#266) * fix(go version parts): remove alphabets from the version for validation (#259) * fix(go version parts): remove alphabets from the version for validation - Go versions like 1.12rc1 or 1.16beta1 are supported. - Test added. * fix: use regex for go versions * chore: aws lambda builders version set to 1.7.0 (#269) * test: Temporarily disabling two Python integration tests failing on Windows (#282) * feat: Allow Node.js projects to be built without requiring a package.json (#284) * Allow nodejs to build without requiring a manifest * Fix existing tests * Remove expected .package-lock * Define actions in the scope they're used * feat: ARM support (#25) (#287) Co-authored-by: Mathieu Grandis <[email protected]> * chore: bump version to 1.8.0 (#288) * fix: remove rendundant get_go_versions method (#290) Co-authored-by: Sriram Madapusi Vasudevan <[email protected]> Co-authored-by: Cosh_ <[email protected]> Co-authored-by: Mathieu Grandis <[email protected]> Co-authored-by: Daniel Mil <[email protected]>
CoshUS
added a commit
that referenced
this pull request
Sep 29, 2021
* fix: improve support for pep517 builds (#265) * A pep517 build can declare build dependencies. Pip will then know to install these dependencies before trying to build a wheel file. * When creating a build environment, it's only guaranteed to last for the duration of the build process. It's not accessible once a pip command finishes running. * When we try to retrieve the version of a package we run a "modified" form of "python setup.py egg_info". * The problem with this is that we're not using the build environment that has all the build dependencies installed (it's already gone), so if setup.py imports a module (e.g. cython) because it expects it to be there because it declared it as a build dependency the egg_info command will fail. * We don't check the RC or have a fallback case if we can't generate egg info. * We fail with an indecipherable IndexError. We now have a fallback where if we can't import/run the setup.py file, we assume the PKG-INFO file should be in the top level directory of the sdist so we check if it's there, and if so we use that file. * Fixed Unit Test Requiring "test" Binary (#266) * fix(go version parts): remove alphabets from the version for validation (#259) * fix(go version parts): remove alphabets from the version for validation - Go versions like 1.12rc1 or 1.16beta1 are supported. - Test added. * fix: use regex for go versions * chore: aws lambda builders version set to 1.7.0 (#269) * test: Temporarily disabling two Python integration tests failing on Windows (#282) * feat: Allow Node.js projects to be built without requiring a package.json (#284) * Allow nodejs to build without requiring a manifest * Fix existing tests * Remove expected .package-lock * Define actions in the scope they're used * feat: ARM support (#25) (#287) Co-authored-by: Mathieu Grandis <[email protected]> * chore: bump version to 1.8.0 (#288) * fix: remove rendundant get_go_versions method (#290) Co-authored-by: Sriram Madapusi Vasudevan <[email protected]> Co-authored-by: Cosh_ <[email protected]> Co-authored-by: Mathieu Grandis <[email protected]> Co-authored-by: Daniel Mil <[email protected]> Co-authored-by: Sriram Madapusi Vasudevan <[email protected]> Co-authored-by: Cosh_ <[email protected]> Co-authored-by: Mathieu Grandis <[email protected]> Co-authored-by: Daniel Mil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#189
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.