Fix missing dependency of setuptools #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My PR #181 will include this change since I switched to Python 3.12 in PR validation CI. |
BewareMyPower
approved these changes
Dec 26, 2023
RobertIndie
added a commit
that referenced
this pull request
Dec 26, 2023
## Motivation There are some errors blocking the CI: https://github.com/apache/pulsar-client-python/actions/runs/7321925272/job/19942911045?pr=181 https://github.com/apache/pulsar-client-python/actions/runs/7320564743/job/19942264377 The python 3.12 has removed the setuptools for the default dependency by this PR: python/cpython#95299 > [gh-95299](python/cpython#95299): Do not pre-install setuptools in virtual environments created with [venv](https://docs.python.org/3/library/venv.html#module-venv). This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the [activated](https://docs.python.org/3/library/venv.html#venv-explanation) virtual environment. ## Verification Verification CI: https://github.com/apache/pulsar-client-python/actions/runs/7325997832 The result of CI shows that this fix could build the release wheel file successfully. (cherry picked from commit eafc672)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are some errors blocking the CI:
https://github.com/apache/pulsar-client-python/actions/runs/7321925272/job/19942911045?pr=181
https://github.com/apache/pulsar-client-python/actions/runs/7320564743/job/19942264377
The python 3.12 has removed the setuptools for the default dependency by this PR: python/cpython#95299
Verification
Verification CI: https://github.com/apache/pulsar-client-python/actions/runs/7325997832
The result of CI shows that this fix could build the release wheel file successfully.