Skip to content

Commit eafc672

Browse files
authored
Fix missing dependency of setuptools (#183)
## Motivation There are some errors blocking the CI: https://github.com/apache/pulsar-client-python/actions/runs/7321925272/job/19942911045?pr=181 https://github.com/apache/pulsar-client-python/actions/runs/7320564743/job/19942264377 The python 3.12 has removed the setuptools for the default dependency by this PR: python/cpython#95299 > [gh-95299](python/cpython#95299): Do not pre-install setuptools in virtual environments created with [venv](https://docs.python.org/3/library/venv.html#module-venv). This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the [activated](https://docs.python.org/3/library/venv.html#venv-explanation) virtual environment. ## Verification Verification CI: https://github.com/apache/pulsar-client-python/actions/runs/7325997832 The result of CI shows that this fix could build the release wheel file successfully.
1 parent e667570 commit eafc672

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/ci-build-release-wheels.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ jobs:
199199
shell: bash
200200
run: |
201201
cmake --build build --config Release --target install
202-
python -m pip install wheel
202+
python -m pip install wheel setuptools
203203
python setup.py bdist_wheel
204204
python -m pip install ./dist/*.whl
205205
python -c 'import pulsar; c = pulsar.Client("pulsar://localhost:6650"); c.close()'

.github/workflows/ci-pr-validation.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ jobs:
237237
shell: bash
238238
run: |
239239
cmake --build build --config Release --target install
240-
python -m pip install wheel
240+
python -m pip install wheel setuptools
241241
python setup.py bdist_wheel
242242
python -m pip install ./dist/*.whl
243243
python -c 'import pulsar; c = pulsar.Client("pulsar://localhost:6650"); c.close()'

pkg/mac/build-dependencies.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ PYTHON_VERSION_LONG=$2
2929
source pkg/mac/common.sh
3030
source build-support/dep-url.sh
3131

32-
pip3 install pyyaml
32+
pip3 install pyyaml setuptools
3333

3434
dep=$ROOT_DIR/build-support/dep-version.py
3535
PYBIND11_VERSION=$($dep pybind11)

0 commit comments

Comments
 (0)