-
Notifications
You must be signed in to change notification settings - Fork 12k
Update to istanbul-instrumenter-loader 3.0.0 #9030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0
Update loader-utils to version 1.1.0
Rever loader-utils version to 1.0.2
Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0
update istanbul-instrumenter-loader from version 2.0.0 => 3.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure what's causing that error you see (#9002 (comment))... the PR looks ok to me really. The only thing missing is a squashed commit and a correct commit message.
Can you squash into a single commit named fix(@angular/cli): update to istanbul-instrumenter-loader 3.0.0
please?
Then full CI will run and we'll know if something truly breaks.
Sorry I made the commits through the web-ui and I don’t have access to squash and merge…
From: Filipe Silva [mailto:[email protected]]
Sent: Friday, December 29, 2017 11:09 AM
To: angular/angular-cli <[email protected]>
Cc: LaCroix, John (GE Healthcare) <[email protected]>; Author <[email protected]>
Subject: EXT: Re: [angular/angular-cli] Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0 (#9030)
@filipesilva requested changes on this pull request.
Unsure what's causing that error you see... the PR looks ok to me really. The only thing missing is a squashed commit and a correct commit message.
Can you squash into a single commit named fix(@angular/cli): update to istanbul-instrumenter-loader 3.0.0 please?
Then we'll full CI will run and we'll know if something truly breaks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#9030 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AhHFxrnXsDMDD25Vc_lpVOZmAY_fdlSrks5tFQ6qgaJpZM4RPNfm>.
|
No worries, I'll put up a separate PR that supersedes this one then. |
Superseded by #9033. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.