Update to istanbul-instrumenter-loader 3.0.0 #9030
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0
Update loader-utils to version 1.1.0
Rever loader-utils version to 1.0.2
Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0
update istanbul-instrumenter-loader from version 2.0.0 => 3.0.0
filipesilva
suggested changes
Dec 29, 2017
There was a problem hiding this comment.
Unsure what's causing that error you see (#9002 (comment))... the PR looks ok to me really. The only thing missing is a squashed commit and a correct commit message.
Can you squash into a single commit named fix(@angular/cli): update to istanbul-instrumenter-loader 3.0.0 please?
Then full CI will run and we'll know if something truly breaks.
johnlacr
changed the title
|
Sorry I made the commits through the web-ui and I don’t have access to squash and merge…
From: Filipe Silva [mailto:[email protected]]
Sent: Friday, December 29, 2017 11:09 AM
To: angular/angular-cli <[email protected]>
Cc: LaCroix, John (GE Healthcare) <[email protected]>; Author <[email protected]>
Subject: EXT: Re: [angular/angular-cli] Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0 (#9030)
@filipesilva requested changes on this pull request.
Unsure what's causing that error you see... the PR looks ok to me really. The only thing missing is a squashed commit and a correct commit message.
Can you squash into a single commit named fix(@angular/cli): update to istanbul-instrumenter-loader 3.0.0 please?
Then we'll full CI will run and we'll know if something truly breaks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#9030 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AhHFxrnXsDMDD25Vc_lpVOZmAY_fdlSrks5tFQ6qgaJpZM4RPNfm>.
|
|
No worries, I'll put up a separate PR that supersedes this one then. |
|
Superseded by #9033. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.