Skip to content

Update to istanbul-instrumenter-loader 3.0.0 #9030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

johnlacr
Copy link

No description provided.

Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0
Update loader-utils to version 1.1.0
Rever loader-utils version to 1.0.2
Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0
update istanbul-instrumenter-loader from version 2.0.0 => 3.0.0
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure what's causing that error you see (#9002 (comment))... the PR looks ok to me really. The only thing missing is a squashed commit and a correct commit message.

Can you squash into a single commit named fix(@angular/cli): update to istanbul-instrumenter-loader 3.0.0 please?

Then full CI will run and we'll know if something truly breaks.

@johnlacr johnlacr changed the title Update istanbul-instrumenter-loader version from 2.0.0 => 3.0.0 Update to istanbul-instrumenter-loader 3.0.0 Dec 29, 2017
@filipesilva filipesilva self-assigned this Dec 29, 2017
@johnlacr
Copy link
Author

johnlacr commented Dec 29, 2017 via email

@filipesilva
Copy link
Contributor

No worries, I'll put up a separate PR that supersedes this one then.

@filipesilva
Copy link
Contributor

Superseded by #9033.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants