plans to upgrade to v3.0.0 for istanbul-instrumenter-loader ?

[johnlacr]

We recently converted our project to angular5 and the parseQuery() webpack deprecation warning is causing problems with our build. I think moving the istanbul-instrumenter-loader from version 2.0.0 => 3.0.0 would help.

[filipesilva]

Would you be interested in submitting a PR?

[filipesilva]

The files you should update are the same as the ones in 37abd83.

[johnlacr]

I'll try. I forked 1.6.3 and and trying to make the changes now (I'm new at this). I will add the file versions you mentioned to the packages.json...I only updated the version for the istanbul-instrumenter-loader.

[filipesilva]

Oh you just need to change istanbul-instrumenter-loader really. I used that PR as an example because it's a simple update PR. Please remember to update package-lock.json as well though!

[johnlacr]

I made the updates (including package-lock.json), but something else is wrong. I completely cleaned out my system and when I do an npm install I am getting this: C:\Users\Administrator>ng --version module.js:514 if (content.charCodeAt(0) === 35/*#*/ && ^ TypeError: content.charCodeAt is not a function at Module._compile (module.js:514:17) at Object.require.extensions..ts (C:\Users\Administrator\AppData\Roaming\npm\node_modules\@angular\cli\lib\bootstrap-local.js:25:14) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.require (module.js:497:17) at require (internal/module.js:20:19) at Object.<anonymous> (C:\Users\Administrator\AppData\Roaming\npm\node_modules\@angular\cli\packages\@angular\cli\bin\ng:8:46) at Module._compile (module.js:570:32) at Object.Module._extensions..js (module.js:579:10) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.require (module.js:497:17) at require (internal/module.js:20:19) at Object.<anonymous> (C:\Users\Administrator\AppData\Roaming\npm\node_modules\@angular\cli\bin\ng:9:1) at Module._compile (module.js:570:32) at Object.Module._extensions..js (module.js:579:10) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.runMain (module.js:604:10) at run (bootstrap_node.js:389:7) at startup (bootstrap_node.js:149:9) at bootstrap_node.js:502:3 If I do an npm uninstall, and re-install the base version 1.6.3 code it works fine. Is it possible that moving the something else is version dependent on the Istanbul-instrumenter-loader version, and if so how to I figure out what it is? From: Filipe Silva [mailto:notifications@github.com] Sent: Thursday, December 28, 2017 12:35 PM To: angular/angular-cli <angular-cli@noreply.github.com> Cc: LaCroix, John (GE Healthcare) <John.LaCroix@ge.com>; Author <author@noreply.github.com> Subject: EXT: Re: [angular/angular-cli] plans to upgrade to v3.0.0 for istanbul-instrumenter-loader ? (#9002) Oh you just need to change istanbul-instrumenter-loader really. I used that PR as an example because it's a simple update PR. Please remember to update package-lock.json as well though! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9002 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AhHFxpU7Nx6f-ygnyRdUOZvJse0UeeDcks5tE9FbgaJpZM4RM6_n>.

[filipesilva]

The error you're getting is actually an unfortunate (intended) side effect of our bootstrap. It can break if you have incompatible versions of dependencies in your project and linked CLI.

You can either:

• make a custom build of the CLI via npm run build and install the .tgz in your project (instead of linking)
• comment out https://github.com/angular/angular-cli/blob/master/lib/bootstrap-local.js#L83-L88 to force the bootstrap to use the local versions (don't commit this change).

Sorry about that, it's a rather arcane problem.

[johnlacr]

Thanks for the response. I don’t understand the problem with incompatible versions – at the moment, I have removed the node modules folder for my project (along with npm cache clean, etc.) and have only done the global install of @angular/cli from my repository. I don’t get the problem if I use version 1.6.3, again, with no local project installed. I could potentially make the second approach (commenting out the lines) work for our CI process, but when I commented them out I got the same error (there is also the reference to line 25 of that stack dump). Sorry for any confusion on my part. From: Filipe Silva [mailto:notifications@github.com] Sent: Friday, December 29, 2017 10:20 AM To: angular/angular-cli <angular-cli@noreply.github.com> Cc: LaCroix, John (GE Healthcare) <John.LaCroix@ge.com>; Author <author@noreply.github.com> Subject: EXT: Re: [angular/angular-cli] plans to upgrade to v3.0.0 for istanbul-instrumenter-loader ? (#9002) The error you're getting is actually an unfortunate (intended) side effect of our bootstrap. It can break if you have incompatible versions of dependencies in your project and linked CLI. You can either: * make a custom build of the CLI via npm run build and install the .tgz in your project (instead of linking) * comment out https://github.com/angular/angular-cli/blob/master/lib/bootstrap-local.js#L83-L88 to force the bootstrap to use the local versions (don't commit this change). Sorry about that, it's a rather arcane problem. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9002 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AhHFxlo7DArv5CLuMjFSXAWh07isGDUyks5tFQMygaJpZM4RM6_n>.

[filipesilva]

Hm, maybe the error means something else. I'm used to it meaning different versions. Can you put up a PR with your current changes please? I'll take a look locally.

[johnlacr]

Done. From: Filipe Silva [mailto:notifications@github.com] Sent: Friday, December 29, 2017 10:51 AM To: angular/angular-cli <angular-cli@noreply.github.com> Cc: LaCroix, John (GE Healthcare) <John.LaCroix@ge.com>; Author <author@noreply.github.com> Subject: EXT: Re: [angular/angular-cli] plans to upgrade to v3.0.0 for istanbul-instrumenter-loader ? (#9002) Hm, maybe the error means something else. I'm used to it meaning different versions. Can you put up a PR with your current changes please? I'll take a look locally. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#9002 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AhHFxspBq3R1OnI3ew4txKdab6bSjrIjks5tFQp2gaJpZM4RM6_n>.