Multiple Gallery Filters

[jukent]

Closes #125

Step 1 - Add a class associated with each tag to every card

[github-actions]

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 73d86c6
✅ Deployment Preview URL: https://6196e4e471ef9c009a5ae0ca--projectpythia-org.netlify.app

[kmpaul]

Just popping in to say, "Thanks, @jukent!"

[jukent]

Just popping in to say, "Thanks, @jukent!"

Of course! Might have to pick your brain later. :)

[jukent]

Step 2 - Initial JS

[kmpaul]

@jukent: Take a look at the three commits I just made, one to custom.js and one to the yaml_gallery_generator.py file. I changed the JS to modify the classes of the elements instead of the style directly. That way we don't have to compete with Bootstrap's styling. (That is, we actually use Bootstrap styling directly by changing the classes!) And the change to the Python file is to add the tag names to the :column: element of each Sphinx Panel. I think this now actually works the way it is intended...namely, clicking on a tag from any of the dropdown menus toggles the display of that tag. (The last commit just styles the button elements with Bootstrap btn classes so they are pretty.)

This behavior is not exactly what we want, though. In fact, I think I just realized that it is wrong in some ways. For example, imagine you have 2 visible cards with the following tags:

• card1: tag1 tag2
• card2: tag1 tag3

With this implementation, if you "click" tag3, then card2 will be hidden, but card1 will still be visible. Then, if you click tag1, then card1 will be hidden and card2 will be made visible! That's not what we want. And it's result of toggling the state of the cards as hidden or visible.

So, what we need to do is provide a way of selecting and de-selecting tags to display. And I think we need to not use the toggling behavior, but I'm not sure how better to do this.

[jukent]

Hmm that is interesting. We may be able to manipulate the toggling. I'll look into other avenues for this.

[kmpaul]

@ProjectPythia/infrastructure: This PR is failing to build, and the failure says that even though mamba appears to be correctly installed by the conda-incubator/setup-miniconda action, it cannot find mamba. I don't know what is going on here.

This failure is happening on #151, too.

[kmpaul]

@ProjectPythia/infrastructure: This error (mamba not found) is happening on the Foundations repo, too. So, this is a more widespread problem. I don't see any issues in the conda-incubator/setup-miniconda GitHub repo about this, and it seems to have only started in the last 8 hours. If I try to install mamba in my own test environment, it installs and is executable.

[kmpaul]

Ok. I believe the problem is coming from the latest release of mamba (0.18.0). I fixed the version of mamba to 0.17.0 (last releast) and it appears to build, now.

[kmpaul]

@brian-rose @andersy005: This is ready for review, now.

[brian-rose]

I'm reviewing only the functionality because I know nothing about javascript, but I love this! I played around with various checkbox combinations and didn't find any glitches. This is just what I was envisioning when I originally proposed #125.

Great work @jukent and @kmpaul ! This is critical infrastructure.