-
Notifications
You must be signed in to change notification settings - Fork 21
Add Twitter button to Portal Navbar #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tried a few ways to push the navbar Twitter button to the right but am having no luck. I would appreciate another set of eyes on the html, as well as style opinions. Also, maybe it's not that important to have the button on the right? |
@jukent: This is Bootstrap 5, so you need to make sure you are reading the documentation for the correct version of Bootstrap. I fixed the right-align issue, but I think the button seems out of place and doesn't match the theme. Can we change the button to something that looks better with the theme? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Thanks @jukent for adding this
@kmpaul Is there something significantly different between this portal sight and the Xdev blog? I would like to copy the way the Twitter button looks over there, but cannot seem to replicate it. Both are Bootstrap 5 correct? |
No. The Xdev blog is a Nikola site with Bootstrap 4, I think. The portal is a Sphinx site with Bootstrap 5. |
That makes sense then. |
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: d17570f |
Build failure with "Error: Unable to locate executable file: /usr/share/miniconda/condabin/mamba. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable." I don't think this is related to this small change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
@mgrover1: This is read for review, again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks @jukent ! 👍
Closes #136