Skip to content

Add Twitter button to Portal Navbar #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 19, 2021
Merged

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Sep 14, 2021

Closes #136

@jukent jukent added the infrastructure Infrastructure related issue label Sep 15, 2021
@jukent jukent marked this pull request as ready for review September 20, 2021 22:39
@jukent jukent requested a review from a team as a code owner September 20, 2021 22:39
@jukent
Copy link
Contributor Author

jukent commented Sep 20, 2021

I tried a few ways to push the navbar Twitter button to the right but am having no luck. I would appreciate another set of eyes on the html, as well as style opinions. Also, maybe it's not that important to have the button on the right?

@kmpaul
Copy link
Collaborator

kmpaul commented Sep 20, 2021

@jukent: This is Bootstrap 5, so you need to make sure you are reading the documentation for the correct version of Bootstrap.

I fixed the right-align issue, but I think the button seems out of place and doesn't match the theme. Can we change the button to something that looks better with the theme?

mgrover1
mgrover1 previously approved these changes Sep 21, 2021
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thanks @jukent for adding this

@jukent
Copy link
Contributor Author

jukent commented Nov 4, 2021

@kmpaul Is there something significantly different between this portal sight and the Xdev blog? I would like to copy the way the Twitter button looks over there, but cannot seem to replicate it. Both are Bootstrap 5 correct?

@kmpaul
Copy link
Collaborator

kmpaul commented Nov 4, 2021

No. The Xdev blog is a Nikola site with Bootstrap 4, I think. The portal is a Sphinx site with Bootstrap 5.

@jukent
Copy link
Contributor Author

jukent commented Nov 4, 2021

That makes sense then.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2021

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: d17570f
✅ Deployment Preview URL: https://6196e4bb47bc37007154a6c4--projectpythia-org.netlify.app

@jukent
Copy link
Contributor Author

jukent commented Nov 18, 2021

Build failure with "Error: Unable to locate executable file: /usr/share/miniconda/condabin/mamba. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable." I don't think this is related to this small change.

@jukent jukent closed this Nov 18, 2021
@jukent jukent reopened this Nov 18, 2021
@jukent jukent closed this Nov 18, 2021
@jukent jukent removed the request for review from dcamron November 18, 2021 21:00
@jukent jukent reopened this Nov 18, 2021
@jukent jukent mentioned this pull request Nov 18, 2021
@kmpaul kmpaul mentioned this pull request Nov 18, 2021
@kmpaul kmpaul self-requested a review November 18, 2021 22:41
Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@kmpaul
Copy link
Collaborator

kmpaul commented Nov 18, 2021

@mgrover1: This is read for review, again.

Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @jukent ! 👍

@jukent jukent merged commit c4f59ee into ProjectPythia:main Nov 19, 2021
@jukent jukent deleted the twitter branch November 19, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Twitter link to portal
3 participants